pgsql: Use a virtual rather than a heap slot in two places where that s

2019-03-01 Thread Andres Freund
Use a virtual rather than a heap slot in two places where that suffices. Author: Andres Freund Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/70b9bda65f8174e24eef5d8967705485a314a82e

pgsql: Check we don't misoptimize a NOT IN where the subquery returns n

2019-03-01 Thread Tom Lane
Check we don't misoptimize a NOT IN where the subquery returns no rows. Future-proofing against a common mistake in attempts to optimize NOT IN. We don't have such an optimization right now, but attempts to do so are in the works, and some of 'em are buggy. Add a regression test case covering the

pgsql: Teach optimizer's predtest.c more things about ScalarArrayOpExpr

2019-03-01 Thread Tom Lane
Teach optimizer's predtest.c more things about ScalarArrayOpExpr. In particular, make it possible to prove/refute "x IS NULL" and "x IS NOT NULL" predicates from a clause involving a ScalarArrayOpExpr even when we are unable or unwilling to deconstruct the expression into an AND/OR tree. This avo

pgsql: Fix whitespace

2019-03-01 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aad21d4c3cd84e7c2a28d239048d2e2f494be47e Modified Files -- src/interfaces/ecpg/ecpglib/misc.c | 12 +- src/interfaces/ecpg/ecpglib/prepare.c | 8 +- src/interfac

pgsql: Remove tests for pg_dumpall --exclude-database missing argument

2019-03-01 Thread Andrew Dunstan
Remove tests for pg_dumpall --exclude-database missing argument It turns out that different getopt implementations spell the error for missing arguments different ways. This test is of fairly marginal value, so instead of trying to keep up with the different error messages just remove the test.

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Tom Lane
Andrew Dunstan writes: > [ getopt has platform-dependent error message spelling ] > > I'm somewhat inclined just to abandon the test. It's at best of marginal > use. Agreed. It seems barely worth the test cycles to begin with, and surely not worth coping with all the different ways this error me

pgsql: Store tuples for EvalPlanQual in slots, rather than as HeapTuple

2019-03-01 Thread Andres Freund
Store tuples for EvalPlanQual in slots, rather than as HeapTuples. For the upcoming pluggable table access methods it's quite inconvenient to store tuples as HeapTuples, as that'd require converting tuples from a their native format into HeapTuples. Instead use slots to manage epq tuples. To fit

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
On 3/1/19 12:56 PM, Andrew Dunstan wrote: > On 3/1/19 12:04 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Add --exclude-database option to pg_dumpall >> Buildfarm seems to think you got the test case wrong ... >> >> > > Hmm, Of course I tested this. It's passing on Linu

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
On 3/1/19 12:04 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Add --exclude-database option to pg_dumpall > Buildfarm seems to think you got the test case wrong ... > > Hmm, Of course I tested this. It's passing on Linux boxes like crake and prion, but failing on OSX a

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Tom Lane
Andrew Dunstan writes: > Add --exclude-database option to pg_dumpall Buildfarm seems to think you got the test case wrong ... regards, tom lane

pgsql: Add extra descriptive headings in pg_dumpall

2019-03-01 Thread Andrew Dunstan
Add extra descriptive headings in pg_dumpall Headings are added for the User Configurations and Databases sections, and for each user configuration and database in the output. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.181227130.32444@lancre Branch -- master D

pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
Add --exclude-database option to pg_dumpall This option functions similarly to pg_dump's --exclude-table option, but for database names. The option can be given once, and the argument can be a pattern including wildcard characters. Author: Andrew Dunstan. Reviewd-by: Fabien Coelho and Michael Paq