Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

On Tue, Mar 19, 2019 at 11:01 AM Michael Paquier wrote: > > On Mon, Mar 18, 2019 at 09:53:23PM -0400, Tom Lane wrote: > > The buildfarm's not too happy with this, which I suspect traces > > to the fact that you neglected to fix copyfuncs.c and equalfuncs.c. > > If you use -DDCOPY_PARSE_PLAN_TREES

pgsql: Fix copyfuncs/equalfuncs support for VacuumStmt.

Fix copyfuncs/equalfuncs support for VacuumStmt. Commit 6776142a07afb4c28961f27059d800196902f5f1 failed to do this, and the buildfarm broke. Patch by me, per advice from Tom Lane and Michael Paquier. Discussion: http://postgr.es/m/[email protected] Branch -- master Details ---

Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

On Mon, Mar 18, 2019 at 09:53:23PM -0400, Tom Lane wrote: > The buildfarm's not too happy with this, which I suspect traces > to the fact that you neglected to fix copyfuncs.c and equalfuncs.c. If you use -DDCOPY_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST, I am pretty sure that you will be ab

Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

Robert Haas writes: > Revise parse tree representation for VACUUM and ANALYZE. The buildfarm's not too happy with this, which I suspect traces to the fact that you neglected to fix copyfuncs.c and equalfuncs.c. regards, tom lane

pgsql: Implement OR REPLACE option for CREATE AGGREGATE.

Implement OR REPLACE option for CREATE AGGREGATE. Aggregates have acquired a dozen or so optional attributes in recent years for things like parallel query and moving-aggregate mode; the lack of an OR REPLACE option to add or change these for an existing agg makes extension upgrades gratuitously h

pgsql: Fix error message in pg_verify_checksums

Fix error message in pg_verify_checksums 5864d24 has introduced a new error message, and I somewhat managed to fail adapting the back-patched version correctly with the tool name. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/31eb62d55ed97f9879f0bc0df2ba5c0

pgsql: Fix memory leak in printtup.c.

Fix memory leak in printtup.c. Commit f2dec34e1 changed things so that printtup's output stringinfo buffer was allocated outside the per-row temporary context, not inside it. This creates a need to free that buffer explicitly when the temp context is freed, but that was overlooked. In most cases

pgsql: Fix memory leak in printtup.c.

Fix memory leak in printtup.c. Commit f2dec34e1 changed things so that printtup's output stringinfo buffer was allocated outside the per-row temporary context, not inside it. This creates a need to free that buffer explicitly when the temp context is freed, but that was overlooked. In most cases

pgsql: Fix typos in sgml docs about RefetchForeignRow().

Fix typos in sgml docs about RefetchForeignRow(). I screwed this up in ad0bda5d24e. Reported-By: Jie Zhang, Michael Paquier, Etsuro Fujita Discussion: https://postgr.es/m/1396E95157071C4EBBA51892C5368521017F2DA203@G08CNEXMBPEKD02.g08.fujitsu.local Branch -- master Details --- https://g

pgsql: Remove leftover reference to oid column.

Remove leftover reference to oid column. I (Andres) missed this in 578b229718e8. Author: John Naylor Discussion: https://postgr.es/m/cacpnzctd+ckugibrfs9kewk4yr5rj3oipefquupw+xjzebf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7571ce6f11f24594

pgsql: Don't auto-restart per-database autoprewarm workers.

Don't auto-restart per-database autoprewarm workers. We should try to prewarm each database only once. Otherwise, if prewarming fails for some reason, it will just keep retrying in an infnite loop. This can happen if, for example, the database has been dropped. The existing code was intended to

pgsql: Don't auto-restart per-database autoprewarm workers.

Don't auto-restart per-database autoprewarm workers. We should try to prewarm each database only once. Otherwise, if prewarming fails for some reason, it will just keep retrying in an infnite loop. This can happen if, for example, the database has been dropped. The existing code was intended to

pgsql: Revise parse tree representation for VACUUM and ANALYZE.

Revise parse tree representation for VACUUM and ANALYZE. Like commit f41551f61f9cf4eedd5b7173f985a3bdb4d9858c, this aims to make it easier to add non-Boolean options to VACUUM (or, in this case, to ANALYZE). Instead of building up a bitmap of options directly in the parser, build up a list of Def

Re: pgsql: Add support for collation attributes on older ICU versions

Hi, On 2019-03-17 07:47:45 +, Peter Eisentraut wrote: > Add support for collation attributes on older ICU versions > > Starting in ICU 54, collation customization attributes can be > specified in the locale string, for example > "@colStrength=primary;colCaseLevel=yes". Add support for this f

pgsql: Fold vacuum's 'int options' parameter into VacuumParams.

Fold vacuum's 'int options' parameter into VacuumParams. Many places need both, so this allows a few functions to take one fewer parameter. More importantly, as soon as we add a VACUUM option that takes a non-Boolean parameter, we need to replace 'int options' with a struct, and it seems better t

pgsql: Fix optimization of foreign-key on update actions

Fix optimization of foreign-key on update actions In RI_FKey_pk_upd_check_required(), we check among other things whether the old and new key are equal, so that we don't need to run cascade actions when nothing has actually changed. This was using the equality operator. But the effect of this is

pgsql: Remove unused macro

Remove unused macro It has never been used. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fb5806533f9fe0433290d84c9b019399cd69e9c2 Modified Files -- src/bin/pg_dump/parallel.c | 2 -- 1 file changed, 2 deletions(-)