Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

2019-03-19 Thread Michael Paquier
On Tue, Mar 19, 2019 at 11:09:25AM -0300, Alvaro Herrera wrote: > We already discussed this one, remember? Anyway, I've avoided Latin > names in further animals to forestall this problem. Of course I remember! Not being able to remember how to spell that is another problem, and my own issue :) -

pgsql: Hack back-branch SSL tests to avoid intermittent buildfarm failu

2019-03-19 Thread Tom Lane
Hack back-branch SSL tests to avoid intermittent buildfarm failures. Buildfarm member eelpout sometimes reports the wrong error message for an SSL connection failure. In HEAD, this problem is believed to be solved by commit 1f39a1c06, but I'm as yet unwilling to back-patch that. The problem seems

pgsql: Restructure libpq's handling of send failures.

2019-03-19 Thread Tom Lane
Restructure libpq's handling of send failures. Originally, if libpq got a failure (e.g., ECONNRESET) while trying to send data to the server, it would just report that and wash its hands of the matter. It was soon found that that wasn't a very pleasant way of coping with server-initiated disconne

pgsql: Rename typedef in jsonpath_gram.y from "string" to "JsonPathStri

2019-03-19 Thread Alexander Korotkov
Rename typedef in jsonpath_gram.y from "string" to "JsonPathString" Reason is the same as in 75c57058b0. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5e28b778bf9a5835e702277119c5f92b4dbab45e Modified Files -- src/backend/utils/adt/jsonpath_gram.y | 1

pgsql: Tweak nbtsearch.c function prototype order.

2019-03-19 Thread Peter Geoghegan
Tweak nbtsearch.c function prototype order. nbtsearch.c's static function prototypes were slightly out of order. Make the order consistent with static function definition order. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1009920aaa39e19ecb36409447ece2f8102f4225

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

pgsql: Make checkpoint requests more robust.

2019-03-19 Thread Tom Lane
Make checkpoint requests more robust. Commit 6f6a6d8b1 introduced a delay of up to 2 seconds if we're trying to request a checkpoint but the checkpointer hasn't started yet (or, much less likely, our kill() call fails). However buildfarm experience shows that that's not quite enough for slow or h

Re: pgsql: Add support for collation attributes on older ICU versions

2019-03-19 Thread Andres Freund
On 2019-03-19 09:49:14 +0100, Peter Eisentraut wrote: > On 2019-03-18 20:03, Andres Freund wrote: > > I now get this warning: > > > > /home/andres/src/postgresql/src/backend/utils/adt/pg_locale.c:1680:14: > > warning: comparison of constant -1 with expression of type 'UColAttribute' > > is alway

Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

2019-03-19 Thread Alvaro Herrera
On 2019-Mar-19, Michael Paquier wrote: > See calliphoridae (still don't know how to pronounce that without > wikipedia-sensei): We already discussed this one, remember? Anyway, I've avoided Latin names in further animals to forestall this problem. -- Álvaro Herrerahttps://www.2

Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.

2019-03-19 Thread Tom Lane
Masahiko Sawada writes: > On Tue, Mar 19, 2019 at 11:01 AM Michael Paquier wrote: >> On Mon, Mar 18, 2019 at 09:53:23PM -0400, Tom Lane wrote: >>> The buildfarm's not too happy with this, which I suspect traces >>> to the fact that you neglected to fix copyfuncs.c and equalfuncs.c. >> If you use

pgsql: Reorder LOCALLOCK structure members to compact the size

2019-03-19 Thread Peter Eisentraut
Reorder LOCALLOCK structure members to compact the size Save 8 bytes (on x86-64) by filling up padding holes. Author: Takayuki Tsunakawa Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgre

pgsql: Rename typedef in jsonpath_scan.l from "keyword" to "JsonPathKey

2019-03-19 Thread Alexander Korotkov
Rename typedef in jsonpath_scan.l from "keyword" to "JsonPathKeyword" Typedef name should be both unique and non-intersect with variable names across all the sources. That makes both pg_indent and debuggers happy. Discussion: https://postgr.es/m/23865.1552936099%40sss.pgh.pa.us Branch -- ma

pgsql: Ignore attempts to add TOAST table to shared or catalog tables

2019-03-19 Thread Peter Eisentraut
Ignore attempts to add TOAST table to shared or catalog tables Running ALTER TABLE on any table will check if a TOAST table needs to be added. On shared tables, this would previously fail, thus effectively disabling ALTER TABLE for those tables. On (non-shared) system catalogs, on the other hand

pgsql: Fix whitespace

2019-03-19 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e537ac5182f8cfa7244a8c8ae772b787b2288605 Modified Files -- src/backend/utils/adt/jsonpath_gram.y | 1 - src/backend/utils/adt/jsonpath_scan.l | 1 - 2 files changed, 2 deletions(-)

Re: pgsql: Add support for collation attributes on older ICU versions

2019-03-19 Thread Peter Eisentraut
On 2019-03-18 20:03, Andres Freund wrote: > I now get this warning: > > /home/andres/src/postgresql/src/backend/utils/adt/pg_locale.c:1680:14: > warning: comparison of constant -1 with expression of type 'UColAttribute' is > always true [-Wtautological-constant-out-of-range-compare] >

pgsql: Fix bug in support for collation attributes on older ICU version

2019-03-19 Thread Peter Eisentraut
Fix bug in support for collation attributes on older ICU versions Unrecognized attribute names are supposed to be ignored. But the code would error out on an unrecognized attribute value even if it did not recognize the attribute name. So unrecognized attributes wouldn't really be ignored unless