pgsql: GSSAPI: Improve documentation and tests

2019-04-19 Thread Stephen Frost
GSSAPI: Improve documentation and tests The GSSAPI encryption patch neglected to update the protocol documentation to describe how to set up a GSSAPI encrypted connection from a client to the server, so fix that by adding the appropriate documentation to protocol.sgml. The tests added for encrypt

pgsql: Fix slot type issue for fuzzy distance index scan over out-of-co

2019-04-19 Thread Andres Freund
Fix slot type issue for fuzzy distance index scan over out-of-core table AM. For amcanreorderby scans the nodeIndexscan.c's reorder queue holds heap tuples, but the underlying table likely does not. Before this fix we'd return different types of slots, depending on whether the tuple came from the

pgsql: Fix two memory leaks around force-storing tuples in slots.

2019-04-19 Thread Andres Freund
Fix two memory leaks around force-storing tuples in slots. As reported by Tom, when ExecStoreMinimalTuple() had to perform a conversion to store the minimal tuple in the slot, it forgot to respect the shouldFree flag, and leaked the tuple into the current memory context if true. Fix that by freei

pgsql: Fix problems with auto-held portals.

2019-04-19 Thread Tom Lane
Fix problems with auto-held portals. HoldPinnedPortals() did things in the wrong order: it must not mark a portal autoHeld until it's been successfully held. Otherwise, a failure while persisting the portal results in a server crash because we think the portal is in a good state when it's not. A

pgsql: Fix problems with auto-held portals.

2019-04-19 Thread Tom Lane
Fix problems with auto-held portals. HoldPinnedPortals() did things in the wrong order: it must not mark a portal autoHeld until it's been successfully held. Otherwise, a failure while persisting the portal results in a server crash because we think the portal is in a good state when it's not. A

pgsql: Fix collection of typos and grammar mistakes in docs and comment

2019-04-19 Thread Michael Paquier
Fix collection of typos and grammar mistakes in docs and comments Author: Justin Pryzby Discussion: https://postgr.es/m/20190330224333.gq5...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/148266fa354a47543f6c0325cd1ea900ead4aac6 Modified Files -

pgsql: Clean up some documentation for log_statement_sample_rate

2019-04-19 Thread Michael Paquier
Clean up some documentation for log_statement_sample_rate This was missing from 88bdbd3. Author: Christoph Berg, Justin Pryzby Discussion: https://postgr.es/m/20190403215938.GA26375@alvherre.pgsql Discussion: https://postgr.es/m/20190330224333.gq5...@telsasoft.com Branch -- master Details -

Re: pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-04-19 Thread Amit Langote
On 2019/04/19 4:41, Tom Lane wrote: > Amit Langote writes: >> On 2019/02/23 2:23, Tom Lane wrote: >>> Fix plan created for inherited UPDATE/DELETE with all tables excluded. > >> I noticed that we may have forgotten to fix one more thing in this commit >> -- nominalRelation may refer to a range ta