pgsql: Fix potential catalog corruption with temporary identity columns

2019-04-28 Thread Peter Eisentraut
Fix potential catalog corruption with temporary identity columns If a temporary table with an identity column and ON COMMIT DROP is created in a single-statement transaction (not useful, but allowed), it would leave the catalog corrupted. We need to add a CommandCounterIncrement() so that PreComm

Re: pgsql: Add viewBox attribute to storage page layout SVG image

2019-04-28 Thread Peter Eisentraut
On 2019-04-27 17:37, Joe Conway wrote: > Add viewBox attribute to storage page layout SVG image The SVG images are not supposed to be edited. This needs a different solution. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training

pgsql: Do pre-release housekeeping on catalog data, and fix jsonpath se

2019-04-28 Thread Tom Lane
Do pre-release housekeeping on catalog data, and fix jsonpath send/recv. Run renumber_oids.pl to move high-numbered OIDs down, as per pre-beta tasks specified by RELEASE_CHANGES. (The only change is 8394 -> 3428.) Also run reformat_dat_file.pl while I'm here. While looking at the reformat diffs

pgsql: Use preprocessor conditions compatible with Emacs indent.

2019-04-28 Thread Noah Misch
Use preprocessor conditions compatible with Emacs indent. Emacs wrongly indented hundreds of subsequent lines. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/90e7f317735159116fdc3f90e287dd688b18a353 Modified Files -- src/backend/postmaster/postmaster.c

pgsql: Clean up minor warnings from buildfarm.

2019-04-28 Thread Tom Lane
Clean up minor warnings from buildfarm. Be more consistent about use of XXXGetDatum macros in new jsonpath code. This is mostly to avoid having code that looks randomly different from everyplace else that's doing the exact same thing. In pg_regress.c, avoid an unreferenced-function warning from

pgsql: Fix more typos and inconsistencies in documentation

2019-04-28 Thread Michael Paquier
Fix more typos and inconsistencies in documentation This fixes a couple of grammar mistakes, typos and inconsistencies in the documentation. Particularly, the configuration parsing allows only "kB" to mean kilobyte but there were references in the docs to "KB". Some instances of the latter are st