pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix potential assertion failure when reindexing a pg_class index

2019-04-29 Thread Andres Freund
Fix potential assertion failure when reindexing a pg_class index. When reindexing individual indexes on pg_class it was possible to either trigger an assertion failure: TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((index)->rd_id))) That's because reindex_index() called

pgsql: Fix several recently introduced issues around handling new relat

2019-04-29 Thread Andres Freund
Fix several recently introduced issues around handling new relation forks. Most of these stem from d25f519107 "tableam: relation creation, VACUUM FULL/CLUSTER, SET TABLESPACE.". 1) To pass data to the relation_set_new_filenode() RelationSetNewRelfilenode() was made to update

pgsql: Remove obsolete _bt_insert_parent() comment.

2019-04-29 Thread Peter Geoghegan
Remove obsolete _bt_insert_parent() comment. Remove a comment that refers to a coding practice that was fully removed by commit a8b8f4db, which introduced MarkBufferDirty(). It looks like the comment was even obsolete before then, since it concerns write-ordering dependencies with synchronous

pgsql: In walreceiver, don't try to do ereport() in a signal handler.

2019-04-29 Thread Tom Lane
In walreceiver, don't try to do ereport() in a signal handler. This is quite unsafe, even for the case of ereport(FATAL) where we won't return control to the interrupted code, and despite this code's use of a flag to restrict the areas where we'd try to do it. It's possible for example that we

pgsql: Fix some typos

2019-04-29 Thread Michael Paquier
Fix some typos Author: Daniel Gustafsson Discussion: https://postgr.es/m/42kEeWei6VxLGh12QbR08hiI5Pm-c3XgbK7qj393PSttEhVbnnQoFXHKzXjPRZLUpndWAfHIuZuUqGZBzyXadmEUCSqm9xphWur_I8vESMA=@yesql.se Branch -- master Details ---

pgsql: Message fixes

2019-04-29 Thread Alvaro Herrera
Message fixes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ffbce803e646e254367a3f0670d8b64604badc50 Modified Files -- src/bin/pg_checksums/pg_checksums.c | 4 ++-- src/bin/pg_rewind/pg_rewind.c | 4 ++-- src/bin/pg_upgrade/check.c | 2

Re: pgsql: Add viewBox attribute to storage page layout SVG image

2019-04-29 Thread Tom Lane
Joe Conway writes: > On 4/29/19 2:06 AM, Peter Eisentraut wrote: >> The SVG images are not supposed to be edited. This needs a different >> solution. > If the viewBox attribute is needed to make this work reasonably and the > tool does not produce it, post production editing of the SVG is not

Re: pgsql: Add viewBox attribute to storage page layout SVG image

2019-04-29 Thread Joe Conway
On 4/29/19 2:06 AM, Peter Eisentraut wrote: > On 2019-04-27 17:37, Joe Conway wrote: >> Add viewBox attribute to storage page layout SVG image > > The SVG images are not supposed to be edited. This needs a different > solution. If the viewBox attribute is needed to make this work reasonably and

pgsql: Fix potential catalog corruption with temporary identity columns

2019-04-29 Thread Peter Eisentraut
Fix potential catalog corruption with temporary identity columns If a temporary table with an identity column and ON COMMIT DROP is created in a single-statement transaction (not useful, but allowed), it would leave the catalog corrupted. We need to add a CommandCounterIncrement() so that

pgsql: Fix potential catalog corruption with temporary identity columns

2019-04-29 Thread Peter Eisentraut
Fix potential catalog corruption with temporary identity columns If a temporary table with an identity column and ON COMMIT DROP is created in a single-statement transaction (not useful, but allowed), it would leave the catalog corrupted. We need to add a CommandCounterIncrement() so that

pgsql: Fix potential catalog corruption with temporary identity columns

2019-04-29 Thread Peter Eisentraut
Fix potential catalog corruption with temporary identity columns If a temporary table with an identity column and ON COMMIT DROP is created in a single-statement transaction (not useful, but allowed), it would leave the catalog corrupted. We need to add a CommandCounterIncrement() so that

Re: pgsql: Add viewBox attribute to storage page layout SVG image

2019-04-29 Thread Peter Eisentraut
On 2019-04-27 17:37, Joe Conway wrote: > Add viewBox attribute to storage page layout SVG image The SVG images are not supposed to be edited. This needs a different solution. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training