Re: pgsql: Fix union for pgstat message types

2019-05-04 Thread Tomas Vondra
On Sat, May 04, 2019 at 07:08:10PM +0200, Magnus Hagander wrote: On Sat, May 4, 2019 at 5:54 PM Tom Lane wrote: Tomas Vondra writes: > On Wed, May 01, 2019 at 10:34:52AM +, Magnus Hagander wrote: >> Fix union for pgstat message types > Should the tempfile bit be backport

pgsql: pg_verify_checksums: Fix message punctuation

2019-05-04 Thread Peter Eisentraut
pg_verify_checksums: Fix message punctuation Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/506af101f3e9d8f475e6a326eb0ad89f7db81eda Modified Files -- src/bin/pg_verify_checksums/pg_verify_checksums.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: pgsql: Fix union for pgstat message types

2019-05-04 Thread Magnus Hagander
On Sat, May 4, 2019 at 5:54 PM Tom Lane wrote: > Tomas Vondra writes: > > On Wed, May 01, 2019 at 10:34:52AM +, Magnus Hagander wrote: > >> Fix union for pgstat message types > > > Should the tempfile bit be backported? That message was added in 9.2. > > It's just cosmetic I think. The main

Re: pgsql: Fix union for pgstat message types

2019-05-04 Thread Tom Lane
Tomas Vondra writes: > On Wed, May 01, 2019 at 10:34:52AM +, Magnus Hagander wrote: >> Fix union for pgstat message types > Should the tempfile bit be backported? That message was added in 9.2. It's just cosmetic I think. The main point of having everything in the union is to make sure the

Re: pgsql: Fix union for pgstat message types

2019-05-04 Thread Tomas Vondra
On Wed, May 01, 2019 at 10:34:52AM +, Magnus Hagander wrote: Fix union for pgstat message types The message type for temp files and for checksum failures were missing from the union. Due to the coding style used there was no compiler error when this happend. So change the code to actively us

pgsql: pg_dump: Fix newline in error message

2019-05-04 Thread Peter Eisentraut
pg_dump: Fix newline in error message The newline was incorrectly dropped in 5a191f697400560fa8f2cc11817072bf9055de73. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dbe43a4746f1c6a0cdf9710734388de27bf29b54 Modified Files -- src/bin/pg_dump/pg_d

pgsql: pg_dump: Fix newline in error message

2019-05-04 Thread Peter Eisentraut
pg_dump: Fix newline in error message The newline was incorrectly dropped in a98c48debcd0620ab07608d53ee08fdb0e7a1edb. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf0720233ec8f82edb6d55d1668347f9ab60e2f6 Modified Files -- src/bin/pg_dump/pg_d

pgsql: Fix set of issues with memory-allocation system calls in fronten

2019-05-04 Thread Michael Paquier
Fix set of issues with memory-allocation system calls in frontend code Like the backend, the frontend has wrappers on top of malloc() and such whose use is recommended. Particularly, it is possible to do memory allocation without issuing an error. Some binaries missed the use of those wrappers,