Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 10:29:16PM -0400, Alvaro Herrera wrote: > Argh. Apologies, sorry for fixing so quickly. No problem. The buildfarm does not complain anymore after the patch, so it looks that we are good. -- Michael signature.asc Description: PGP signature

Re: pgsql: More message style fixes

2019-05-16 Thread Alvaro Herrera
On 2019-May-17, Michael Paquier wrote: > On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: > > Alvaro Herrera writes: > >> More message style fixes > > > > The buildfarm thinks you forgot something. > > One contrib module is impacted, citext, because it uses regexes and it > has multipl

pgsql: Fix regression test outputs

2019-05-16 Thread Michael Paquier
Fix regression test outputs 75445c1 has caused various failures in tests across the tree after updating some error messages, so fix the newly-expected output. Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details

Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 08:22:25PM -0400, Tom Lane wrote: > Looks reasonable, but check if any of the other tests have alternative > expected-files that you need to fix too. I am not noticing anything else. And I have checked once before sending the previous patch, and once again now. If I have

Re: pgsql: More message style fixes

2019-05-16 Thread Tom Lane
Michael Paquier writes: > On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: >> The buildfarm thinks you forgot something. > One contrib module is impacted, citext, because it uses regexes and it > has multiple expected outputs. The attached brings back my build to > green. Thoughts? Lo

Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: > Alvaro Herrera writes: >> More message style fixes > > The buildfarm thinks you forgot something. One contrib module is impacted, citext, because it uses regexes and it has multiple expected outputs. The attached brings back my build t

pgsql: Fix typos in documentatoin of GSSAPI encryption

2019-05-16 Thread Michael Paquier
Fix typos in documentatoin of GSSAPI encryption Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/41998f90ce66425ca6071ac5e170a19bb1498414 Modified Files -

Re: pgsql: More message style fixes

2019-05-16 Thread Tom Lane
Alvaro Herrera writes: > More message style fixes The buildfarm thinks you forgot something. regards, tom lane

pgsql: More message style fixes

2019-05-16 Thread Alvaro Herrera
More message style fixes Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/75445c1515fffa581585f1b72e5b5314c1c395ce Modified Files -- src/backend/commands/copy.c | 6 ++---

pgsql: Remove extra nbtree half-dead internal page check.

2019-05-16 Thread Peter Geoghegan
Remove extra nbtree half-dead internal page check. It's not safe for nbtree VACUUM to attempt to delete a target page whose right sibling is already half-dead, since that would fail the cross-check when VACUUM attempts to re-find a downlink to the right sibling in the parent page. Logic to preven

pgsql: Fix bogus logic for combining range-partitioned columns during p

2019-05-16 Thread Tom Lane
Fix bogus logic for combining range-partitioned columns during pruning. gen_prune_steps_from_opexps's notion of how to do this was overly complicated and underly correct. Per discussion of a report from Alan Jackson (though this fixes only one aspect of that problem). Back-patch to v11 where thi

pgsql: Fix bogus logic for combining range-partitioned columns during p

2019-05-16 Thread Tom Lane
Fix bogus logic for combining range-partitioned columns during pruning. gen_prune_steps_from_opexps's notion of how to do this was overly complicated and underly correct. Per discussion of a report from Alan Jackson (though this fixes only one aspect of that problem). Back-patch to v11 where thi

pgsql: Fix partition pruning to treat stable comparison operators prope

2019-05-16 Thread Tom Lane
Fix partition pruning to treat stable comparison operators properly. Cross-type comparison operators in a btree or hash opclass might be only stable not immutable (this is true of timestamp vs. timestamptz for example). partprune.c ignored this possibility and would perform plan-time pruning with

pgsql: Fix partition pruning to treat stable comparison operators prope

2019-05-16 Thread Tom Lane
Fix partition pruning to treat stable comparison operators properly. Cross-type comparison operators in a btree or hash opclass might be only stable not immutable (this is true of timestamp vs. timestamptz for example). partprune.c ignored this possibility and would perform plan-time pruning with