Re: pgsql: "A void function may not return a value".

2019-05-17 Thread Tom Lane
Andres Freund writes: > On 2019-05-18 04:40:51 +, Tom Lane wrote: >> "A void function may not return a value". > Darn. Thanks. >For C only, warn about a "return" statement with an expression in > a function whose return type is "void", unless the expression type is also >

Re: pgsql: "A void function may not return a value".

2019-05-17 Thread Andres Freund
Hi, On 2019-05-18 04:40:51 +, Tom Lane wrote: > "A void function may not return a value". Darn. Thanks. For C only, warn about a "return" statement with an expression in a function whose return type is "void", unless the expression type is also "void". As a GNU exten

pgsql: "A void function may not return a value".

2019-05-17 Thread Tom Lane
"A void function may not return a value". Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d307954a7d88ed45655d9206bbe1aefc280c09c7 Modified Files -- src/backend/access/table/tableam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: tableam: Don't assume that every AM uses md.c style storage.

2019-05-17 Thread Andres Freund
tableam: Don't assume that every AM uses md.c style storage. Previously various parts of the code routed size requests through RelationGetNumberOfBlocks[InFork]. That works if md.c is used by the AM, but not otherwise. Add a tableam callback to return the size of the table. As not every AM will u

pgsql: tableam: Avoid relying on relation size to determine validity of

2019-05-17 Thread Andres Freund
tableam: Avoid relying on relation size to determine validity of tids. Instead add a tableam callback to do so. To avoid adding per validation overhead, pass a scan to tuple_tid_valid. In heap's case we'd otherwise incurred a RelationGetNumberOfBlocks() call for each tid - which'd have added notic

pgsql: Restructure creation of run-time pruning steps.

2019-05-17 Thread Tom Lane
Restructure creation of run-time pruning steps. Previously, gen_partprune_steps() always built executor pruning steps using all suitable clauses, including those containing PARAM_EXEC Params. This meant that the pruning steps were only completely safe for executor run-time (scan start) pruning.

pgsql: Restructure creation of run-time pruning steps.

2019-05-17 Thread Tom Lane
Restructure creation of run-time pruning steps. Previously, gen_partprune_steps() always built executor pruning steps using all suitable clauses, including those containing PARAM_EXEC Params. This meant that the pruning steps were only completely safe for executor run-time (scan start) pruning.

pgsql: docs: split out sort-skip partition item in PG 12 release notes

2019-05-17 Thread Bruce Momjian
docs: split out sort-skip partition item in PG 12 release notes Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05685897f07e7ae5684f0247157faad1f782f889 Modified Files