pgsql: Remove bug.template file

Remove bug.template file It's outdated and not really in use anymore. Discussion: https://www.postgresql.org/message-id/flat/cf7ed2b1-1ebe-83cf-e05e-d5943f67af2d%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8bbb8166b63eeebd0cb618ddcf7dcaf8c4ba

pgsql: Remove outdated comment in copy.c.

Remove outdated comment in copy.c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fb504c5e4b5ce71e703006375ee2f5e4b57d89c9 Modified Files -- src/backend/commands/copy.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

pgsql: Minimally fix partial aggregation for aggregates that don't have

Minimally fix partial aggregation for aggregates that don't have one argument. For partial aggregation combine steps, AggStatePerTrans->numTransInputs was set to the transition function's number of inputs, rather than the combine function's number of inputs (always 1). That lead to partial aggreg

pgsql: Minimally fix partial aggregation for aggregates that don't have

Minimally fix partial aggregation for aggregates that don't have one argument. For partial aggregation combine steps, AggStatePerTrans->numTransInputs was set to the transition function's number of inputs, rather than the combine function's number of inputs (always 1). That lead to partial aggreg

pgsql: Fix some grammar in documentation of spgist and pgbench

Fix some grammar in documentation of spgist and pgbench Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- REL9_5_STABLE Details --- https://

pgsql: Fix some grammar in documentation of spgist and pgbench

Fix some grammar in documentation of spgist and pgbench Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- REL9_6_STABLE Details --- https://

pgsql: Fix some grammar in documentation of spgist and pgbench

Fix some grammar in documentation of spgist and pgbench Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- master Details --- https://git.pos

pgsql: Fix some grammar in documentation of spgist

Fix some grammar in documentation of spgist Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- REL9_4_STABLE Details --- https://git.postgres

pgsql: Fix some grammar in documentation of spgist and pgbench

Fix some grammar in documentation of spgist and pgbench Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- REL_11_STABLE Details --- https://

pgsql: Fix some grammar in documentation of spgist and pgbench

Fix some grammar in documentation of spgist and pgbench Discussion: https://postgr.es/m/[email protected] Author: Liudmila Mantrova Reviewed-by: Jonathan Katz, Tom Lane, Michael Paquier Backpatch-through: 9.4 Branch -- REL_10_STABLE Details --- https://

pgsql: Fix and improve SnapshotType comments.

Fix and improve SnapshotType comments. The comment for SNAPSHOT_SELF was unfortunately explaining SNAPSHOT_DIRTY, as reported by Sergei. Also expand a few comments, and include a few more comments from heapam_visibility.c, so they're in an AM independent place. Reported-By: Sergei Kornilov Author

pgsql: Revert "In the pg_upgrade test suite, don't write to src/test/re

Revert "In the pg_upgrade test suite, don't write to src/test/regress." This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had multiple defects. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/p

pgsql: Revert "In the pg_upgrade test suite, don't write to src/test/re

Revert "In the pg_upgrade test suite, don't write to src/test/regress." This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had multiple defects. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/p

pgsql: Revert "In the pg_upgrade test suite, don't write to src/test/re

Revert "In the pg_upgrade test suite, don't write to src/test/regress." This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had multiple defects. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Revert "In the pg_upgrade test suite, don't write to src/test/re

Revert "In the pg_upgrade test suite, don't write to src/test/regress." This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had multiple defects. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/p

pgsql: Revert "In the pg_upgrade test suite, don't write to src/test/re

Revert "In the pg_upgrade test suite, don't write to src/test/regress." This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had multiple defects. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/p

Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

Andres Freund writes: > The buildfarm decidedly is not a fan of this: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-05-19%2021%3A43%3A32 Also, dory is showing a different failure mode, in which it's not even getting to the pg_upgrade test: https://buildfarm.postgresq

pgsql: Don't to predicate lock for analyze scans, refactor scan option

Don't to predicate lock for analyze scans, refactor scan option passing. Before this commit, when ANALYZE was run on a table and serializable was used (either by virtue of an explicit BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE, or default_transaction_isolation being set to serializable) a null

Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

Hi, On 2019-05-19 14:54:50 -0700, Andres Freund wrote: > On 2019-05-19 21:40:43 +, Noah Misch wrote: > > In the pg_upgrade test suite, don't write to src/test/regress. > > The buildfarm decidedly is not a fan of this: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-

Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

Hi, On 2019-05-19 21:40:43 +, Noah Misch wrote: > In the pg_upgrade test suite, don't write to src/test/regress. > > When this suite runs installcheck, redirect file creations from > src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a > race condition in "make -j check-wo

Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

Noah Misch writes: > In the pg_upgrade test suite, don't write to src/test/regress. buildfarm is pretty unimpressed :-( regards, tom lane

pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

In the pg_upgrade test suite, don't write to src/test/regress. When this suite runs installcheck, redirect file creations from src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make -j check-world". If the pg_upgrade suite wrote to a given src/test/regres

pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

In the pg_upgrade test suite, don't write to src/test/regress. When this suite runs installcheck, redirect file creations from src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make -j check-world". If the pg_upgrade suite wrote to a given src/test/regres

pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

In the pg_upgrade test suite, don't write to src/test/regress. When this suite runs installcheck, redirect file creations from src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make -j check-world". If the pg_upgrade suite wrote to a given src/test/regres

pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

In the pg_upgrade test suite, don't write to src/test/regress. When this suite runs installcheck, redirect file creations from src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make -j check-world". If the pg_upgrade suite wrote to a given src/test/regres

pgsql: In the pg_upgrade test suite, don't write to src/test/regress.

In the pg_upgrade test suite, don't write to src/test/regress. When this suite runs installcheck, redirect file creations from src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a race condition in "make -j check-world". If the pg_upgrade suite wrote to a given src/test/regres

pgsql: Improve logrotate test so that it meaningfully exercises syslogg

Improve logrotate test so that it meaningfully exercises syslogger. Discussion of bug #15804 reveals that this test didn't really prove that the syslogger child process ever launched successfully, much less did anything. It was only checking that the expected log file gets created, and that's don

pgsql: Revert "postmaster: Start syslogger earlier".

Revert "postmaster: Start syslogger earlier". This commit reverts 57431a911d3a650451d198846ad3194900666152. While that's still a good idea in the abstract, we found out that there are multiple crasher bugs in it on Windows builds, making the logging_collector option unusable on Windows. There's n