pgsql: Fix ordering of GRANT commands in pg_dump for database creation

2019-05-21 Thread Michael Paquier
Fix ordering of GRANT commands in pg_dump for database creation This uses a method similar to 68a7c24f, which guarantees that GRANT commands using the WITH GRANT OPTION are dumped in a way so as cascading dependencies are respected. As databases do not have support for initial privileges via pg_i

pgsql: Fix ordering of GRANT commands in pg_dump for database creation

2019-05-21 Thread Michael Paquier
Fix ordering of GRANT commands in pg_dump for database creation This uses a method similar to 68a7c24f, which guarantees that GRANT commands using the WITH GRANT OPTION are dumped in a way so as cascading dependencies are respected. As databases do not have support for initial privileges via pg_i

pgsql: Fix ordering of GRANT commands in pg_dumpall for database creati

2019-05-21 Thread Michael Paquier
Fix ordering of GRANT commands in pg_dumpall for database creation This uses a method similar to 68a7c24f, which guarantees that GRANT commands using the WITH GRANT OPTION are dumped in a way so as cascading dependencies are respected. As databases do not have support for initial privileges via p

pgsql: Fix ordering of GRANT commands in pg_dumpall for database creati

2019-05-21 Thread Michael Paquier
Fix ordering of GRANT commands in pg_dumpall for database creation This uses a method similar to 68a7c24f, which guarantees that GRANT commands using the WITH GRANT OPTION are dumped in a way so as cascading dependencies are respected. As databases do not have support for initial privileges via p

pgsql: Un-break pg_upgrade regression test.

2019-05-21 Thread Tom Lane
Un-break pg_upgrade regression test. Commit 5af2e976d removed a bit too much from the test.sh invocation. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5eb4a51cb15166392ca3ede6ec58f8f1f820ef53 Modified Files -- src/bin/pg_upgrade/Makefi

Re: pgsql: Implement PREPARE AS statement for ECPG.

2019-05-21 Thread Michael Paquier
On Wed, May 22, 2019 at 03:08:37AM +, Michael Meskes wrote: > Implement PREPARE AS statement for ECPG. > > Besides implementing the new statement this change fix some issues with the > parsing of PREPARE and EXECUTE statements. The different forms of these > statements are now all handled in a

pgsql: Implement PREPARE AS statement for ECPG.

2019-05-21 Thread Michael Meskes
Implement PREPARE AS statement for ECPG. Besides implementing the new statement this change fix some issues with the parsing of PREPARE and EXECUTE statements. The different forms of these statements are now all handled in a ujnified way. Author: Matsumura-san Branch -- master Details

pgsql: pg_upgrade: Avoid check target accidentally breaking make's --ou

2019-05-21 Thread Andres Freund
pg_upgrade: Avoid check target accidentally breaking make's --output-sync. When $(MAKE) is present in a rule, make assumes that target is a submake, and it doesn't need to buffer its output. But in this case it's a shell script that needs buffered output. Avoid that heuristic, by referring to $(MA

pgsql: pg_upgrade: Don't use separate installation for test.

2019-05-21 Thread Andres Freund
pg_upgrade: Don't use separate installation for test. For pg_upgrade's test we (unless prevented by the caller via via NO_TEMP_INSTALL) built a separate installation. That causes an unnecessary slowdown after the infrastructure introduced by dcae5faccab (and unnecessarily duplicates code). Author

pgsql: Tag refs/tags/REL_12_BETA1 was created

2019-05-21 Thread noreply
Tag refs/tags/REL_12_BETA1 was created.

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Andres Freund
Hi, On 2019-05-21 16:47:55 -0400, Tom Lane wrote: > Andres Freund writes: > > -check: test.sh all > > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > > +check: test.sh all temp-install > > + MAKE=$(MAKE) $(with_tem

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Tom Lane
Andres Freund writes: > -check: test.sh all > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > +check: test.sh all temp-install > + MAKE=$(MAKE) $(with_temp_install) > bindir=$(abs_top_builddir)/tmp_install/$(bind

pgsql: docs: PG 12 relnote adjustments based on feedback from Tom Lane

2019-05-21 Thread Bruce Momjian
docs: PG 12 relnote adjustments based on feedback from Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e719d33fd253fc378871ba4dbf2de41fd2ba462 Modified Files -- doc/src/sgml/relea

pgsql: docs: adjust RECORD PG 12 relnote item

2019-05-21 Thread Bruce Momjian
docs: adjust RECORD PG 12 relnote item Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3468a04a3e498bab755909505e8f7b6023bea493 Modified Files -- doc/src/sgml/release-12.sgml | 11 -

pgsql: doc: adjust PG 12 relnotes item on float digit adjustment

2019-05-21 Thread Bruce Momjian
doc: adjust PG 12 relnotes item on float digit adjustment Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b84a801d6a6737e6d84326b77d98b498402ecad0 Modified Files -- doc/src/sgml/re

pgsql: doc: fix markup for PG 12 rel notes

2019-05-21 Thread Bruce Momjian
doc: fix markup for PG 12 rel notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0fca8285ea533fa669a372c91fdb42265dcf7435 Modified Files -- doc/src/sgml/release-12.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: adjustments for PG 12 release notes

2019-05-21 Thread Bruce Momjian
doc: adjustments for PG 12 release notes Mostly commit messages, attribution, and text, all suggested by Andres Freund. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32fe2e3194c71

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Andres Freund
Hi, On 2019-05-20 17:47:17 -0700, Andres Freund wrote: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > > > 3) The fact that src/bin/pg_upgrade/Makefile invokes test.sh with > > >MAKE=$(MAKE) triggers make, for rea

pgsql: Make pg_upgrade's test.sh less chatty.

2019-05-21 Thread Tom Lane
Make pg_upgrade's test.sh less chatty. The use of "set -x" to echo a subset of the test's commands might've been a good idea during development of this test, but it's been stable for long enough now that the extra output isn't very useful. Also our project expectations have been trending towards

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Tom Lane
Andres Freund writes: > On 2019-05-21 10:20:57 -0400, Tom Lane wrote: >> The least invasive way to do that seems to be as attached, building a >> little knowledge into pg_regress's psql_command() function. Alternatively >> we could add a "bool quiet" parameter to that function so that callers >>

pgsql: Insert temporary debugging output in regression tests.

2019-05-21 Thread Tom Lane
Insert temporary debugging output in regression tests. We're seeing occasional instability in the plans generated for parallel queries on the "a_star" table hierarchy. This suggests that something is changing the planner's stats for those tables, but that should not be happening within a regressi

pgsql: tableam: Move heap-specific logic from needs_toast_table below t

2019-05-21 Thread Robert Haas
tableam: Move heap-specific logic from needs_toast_table below tableam. This allows table AMs to completely suppress TOAST table creation, or to modify the conditions under which they are created. Patch by me. Reviewed by Andres Freund. Discussion: http://postgr.es/m/CA+Tgmoa4O2n=yphqd2perunym

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Andres Freund
Hi, On 2019-05-21 10:20:57 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > >> The other thing I had to do below was to suppress "NOTICE: database > >> "regression" does not exist, skipping". The added createdb is a > >> mighty expensive and grot

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-21 Thread Tom Lane
Andres Freund writes: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: >> The other thing I had to do below was to suppress "NOTICE: database >> "regression" does not exist, skipping". The added createdb is a >> mighty expensive and grotty way to do that, but I didn't immediately >> see a better o