pgsql: Update copyright year.

2019-05-23 Thread Thomas Munro
Update copyright year. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CA%2BhUKGJFWXmtYo6Frd77RR8YXCHz7hJ2mRy5aHV%3D7fJOqDnBHA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c9210f34c621639f896d57cf7bfb5e9be139c91 Modified Files ---

pgsql: Fix typos.

2019-05-23 Thread Thomas Munro
Fix typos. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CA%2BhUKGJFWXmtYo6Frd77RR8YXCHz7hJ2mRy5aHV%3D7fJOqDnBHA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7988cb446d20512ec9d091db66dba6adee3f3d4b Modified Files --

pgsql: tableam: Rename wrapper functions to match callback names.

2019-05-23 Thread Andres Freund
tableam: Rename wrapper functions to match callback names. Some of the wrapper functions didn't match the callback names. Many of them due to staying "consistent" with historic naming of the wrapped functionality. We decided that for most cases it's more important to be for tableam to be consisten

pgsql: Fix table dump in pg_dump[all] with backends older than 9.5

2019-05-23 Thread Michael Paquier
Fix table dump in pg_dump[all] with backends older than 9.5 The access method name "amname" can be dumped as of 3b925e90, but queries for backends older than 9.5 forgot to map it to a dummy NULL value, causing the column to not be mapped to a number. As a result, pg_dump was throwing some spuriou

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi

2019-05-23 Thread Andres Freund
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. On master (after 700538) the old version's installed psql was used - even when the old version might not actually be installed / might be installed into a temporary directory. As commonly the case when just executing make

pgsql: Fix array size allocation for HashAggregate hash keys.

2019-05-23 Thread Andrew Gierth
Fix array size allocation for HashAggregate hash keys. When there were duplicate columns in the hash key list, the array sizes could be miscomputed, resulting in access off the end of the array. Adjust the computation to ensure the array is always large enough. (I considered whether the duplicate

pgsql: Fix array size allocation for HashAggregate hash keys.

2019-05-23 Thread Andrew Gierth
Fix array size allocation for HashAggregate hash keys. When there were duplicate columns in the hash key list, the array sizes could be miscomputed, resulting in access off the end of the array. Adjust the computation to ensure the array is always large enough. (I considered whether the duplicate

pgsql: Fix array size allocation for HashAggregate hash keys.

2019-05-23 Thread Andrew Gierth
Fix array size allocation for HashAggregate hash keys. When there were duplicate columns in the hash key list, the array sizes could be miscomputed, resulting in access off the end of the array. Adjust the computation to ensure the array is always large enough. (I considered whether the duplicate