pgsql: Rework options of pg_checksums options for filenode handling

2019-05-30 Thread Michael Paquier
Rework options of pg_checksums options for filenode handling This makes the tool consistent with the option set of oid2name, which has been historically using -f for filenodes, and has more recently gained long options and --filenode via 1aaf532. Reported-by: Peter Eisentraut Author: Fabien Coelh

pgsql: Remove unnecessary (and wrong) forward declaration.

2019-05-30 Thread Andres Freund
Remove unnecessary (and wrong) forward declaration. Interestingly only C++ compilers have, so far, complained about this odd forward declaration. This originated when IndexBuildCallback was defined in another file, but now is completely unnecessary (but was wrong before too, cpluspluscheck just wo

pgsql: Make error logging in extended statistics more consistent

2019-05-30 Thread Tomas Vondra
Make error logging in extended statistics more consistent Most errors reported in extended statistics are internal issues, and so should use elog(). The MCV list code was already following this rule, but the functional dependencies and ndistinct coefficients were using a mix of elog() and ereport(

pgsql: Make error logging in extended statistics more consistent

2019-05-30 Thread Tomas Vondra
Make error logging in extended statistics more consistent Most errors reported in extended statistics are internal issues, and so should use elog(). The MCV list code was already following this rule, but the functional dependencies and ndistinct coefficients were using a mix of elog() and ereport(

pgsql: Make error logging in extended statistics more consistent

2019-05-30 Thread Tomas Vondra
Make error logging in extended statistics more consistent Most errors reported in extended statistics are internal issues, and so should use elog(). The MCV list code was already following this rule, but the functional dependencies and ndistinct coefficients were using a mix of elog() and ereport(