Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Michael Paquier
On Mon, Jun 03, 2019 at 09:16:56PM -0400, Tom Lane wrote: > Yeah, I see we already did that in later branches. I'll go fix it, > thanks for the heads-up! Thanks. -- Michael signature.asc Description: PGP signature

pgsql: Mark a few parallelism-related variables with PGDLLIMPORT.

2019-06-03 Thread Tom Lane
Mark a few parallelism-related variables with PGDLLIMPORT. Back-patch commit 09a65f5a2 into the 9.6 and 10 branches. Needed to support back-patch of commit 2cd4e8357 on Windows. Discussion: http://postgr.es/m/20190604011354.gd1...@paquier.xyz Branch -- REL_10_STABLE Details --- https://

pgsql: Mark a few parallelism-related variables with PGDLLIMPORT.

2019-06-03 Thread Tom Lane
Mark a few parallelism-related variables with PGDLLIMPORT. Back-patch commit 09a65f5a2 into the 9.6 and 10 branches. Needed to support back-patch of commit 2cd4e8357 on Windows. Discussion: http://postgr.es/m/20190604011354.gd1...@paquier.xyz Branch -- REL9_6_STABLE Details --- https://

Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Tom Lane
Michael Paquier writes: > On Mon, Jun 03, 2019 at 10:06:21PM +, Tom Lane wrote: >> Fix contrib/auto_explain to not cause problems in parallel workers. > This has broken the builds on Windows for 9.6 and 10: > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2019-06-0

Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Michael Paquier
Hi Tom, On Mon, Jun 03, 2019 at 10:06:21PM +, Tom Lane wrote: > Fix contrib/auto_explain to not cause problems in parallel workers. > > A parallel worker process should not be making any decisions of its > own about whether to auto-explain. If the parent session process > passed down flags a

pgsql: Fix some typos and inconsistencies in tableam.h

2019-06-03 Thread Michael Paquier
Fix some typos and inconsistencies in tableam.h The defined callback definitions have been using references to heap for a couple of variables and comments. This makes the whole interface more consistent by using "table" which is more generic. A variable storing index information was misspelled a

pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Tom Lane
Fix contrib/auto_explain to not cause problems in parallel workers. A parallel worker process should not be making any decisions of its own about whether to auto-explain. If the parent session process passed down flags asking for instrumentation data, do that, otherwise not. Trying to enable ins

pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Tom Lane
Fix contrib/auto_explain to not cause problems in parallel workers. A parallel worker process should not be making any decisions of its own about whether to auto-explain. If the parent session process passed down flags asking for instrumentation data, do that, otherwise not. Trying to enable ins

pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Tom Lane
Fix contrib/auto_explain to not cause problems in parallel workers. A parallel worker process should not be making any decisions of its own about whether to auto-explain. If the parent session process passed down flags asking for instrumentation data, do that, otherwise not. Trying to enable ins

pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

2019-06-03 Thread Tom Lane
Fix contrib/auto_explain to not cause problems in parallel workers. A parallel worker process should not be making any decisions of its own about whether to auto-explain. If the parent session process passed down flags asking for instrumentation data, do that, otherwise not. Trying to enable ins

pgsql: Fix unsafe memory management in CloneRowTriggersToPartition().

2019-06-03 Thread Tom Lane
Fix unsafe memory management in CloneRowTriggersToPartition(). It's not really supported to call systable_getnext() in a different memory context than systable_beginscan() was called in, and it's *definitely* not safe to do so and then reset that context between calls. I'm not very clear on how t

pgsql: Fix unsafe memory management in CloneRowTriggersToPartition().

2019-06-03 Thread Tom Lane
Fix unsafe memory management in CloneRowTriggersToPartition(). It's not really supported to call systable_getnext() in a different memory context than systable_beginscan() was called in, and it's *definitely* not safe to do so and then reset that context between calls. I'm not very clear on how t

pgsql: Update SQL conformance information about JSON path

2019-06-03 Thread Peter Eisentraut
Update SQL conformance information about JSON path Reviewed-by: Oleg Bartunov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05d36b68ed011d112ee287b1fedd981c73a48f85 Modified Files -- src/backend/catalog/sql_features.txt | 14 +++--- src/includ