pgsql: Use strtoint() instead of strtol() in pgtypeslib where the resul

2019-07-02 Thread Michael Meskes
Use strtoint() instead of strtol() in pgtypeslib where the result is stored in an int variable. Author: Yang Xiao Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8372e3c98fbbd529e4545c4d7982e278e118958e Modified Files -- src/interfaces/ecpg/pgtypeslib/

pgsql: Fix small memory leak in ecpglib ecpg_update_declare_statement()

2019-07-02 Thread Michael Meskes
Fix small memory leak in ecpglib ecpg_update_declare_statement() is called the second time. Author: "Zhang, Jie" Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e72489e101b21c328e3d10ca64e5367c60f424a5 Modified Files -- src/interfaces/ecpg/ecpglib/prep

pgsql: Made ecpg compatibility mode and run-time behaviour options case

2019-07-02 Thread Michael Meskes
Made ecpg compatibility mode and run-time behaviour options case insensitive. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/75220fb62b1387b61f92c42b1bd147cb30607012 Modified Files -- src/interfaces/ecpg/preproc/ecpg.c | 8 1 file changed, 4 ins

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This adjusts the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/cajrrpgcfqxhfpymrn

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This adjusts the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/cajrrpgcfqxhfpymrn

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This adjusts the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/cajrrpgcfqxhfpymrn

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This adjusts the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/cajrrpgcfqxhfpymrn

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This adjusts the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/cajrrpgcfqxhfpymrn

pgsql: Add support for Visual Studio 2019 in build scripts

2019-07-02 Thread Michael Paquier
Add support for Visual Studio 2019 in build scripts This fixes at the same time a set of inconsistencies in the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussi

pgsql: Fix accidentally swapped error message arguments

2019-07-02 Thread Peter Eisentraut
Fix accidentally swapped error message arguments Author: Alexey Kondratov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/84c41ae81bdf15cac71cc5ae0af69b4815594522 Modified Files -- src/bin/initdb/initdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

pgsql: Fix accidentally swapped error message arguments

2019-07-02 Thread Peter Eisentraut
Fix accidentally swapped error message arguments Author: Alexey Kondratov Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/91be5387c20dbd9a015b37064cb789a368974b00 Modified Files -- src/bin/initdb/initdb.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Remove redundant newlines from error messages

2019-07-02 Thread Peter Eisentraut
Remove redundant newlines from error messages These are no longer needed/allowed with the new logging API. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7956d7ac9811a6e97b3aef2ad00272c0b72dc7da Modified Files -- src/bin/pg_basebackup/pg_basebac

pgsql: Remove redundant newlines from error messages

2019-07-02 Thread Peter Eisentraut
Remove redundant newlines from error messages These are no longer needed/allowed with the new logging API. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/24c7000f64487323fedb52b8aeadf2c84274dcf5 Modified Files -- src/bin/pg_basebackup/pg_basebackup.c |

pgsql: Fix tab completion of "SET variable TO|=" to not offer bogus com

2019-07-02 Thread Tom Lane
Fix tab completion of "SET variable TO|=" to not offer bogus completions. Don't think that the context "UPDATE tab SET var =" is a GUC-setting command. If we have "SET var =" but the "var" is not a known GUC variable, don't offer any completions. The most likely explanation is that we've mispars

pgsql: Don't treat complete_from_const as equivalent to complete_from_l

2019-07-02 Thread Tom Lane
Don't treat complete_from_const as equivalent to complete_from_list. Commit 4f3b38fe2 supposed that complete_from_const() is equivalent to the one-element-list case of complete_from_list(), but that's not really true at all. complete_from_const() supposes that the completion is certain enough to

pgsql: Fix tab completion of "SET variable TO|=" to not offer bogus com

2019-07-02 Thread Tom Lane
Fix tab completion of "SET variable TO|=" to not offer bogus completions. Don't think that the context "UPDATE tab SET var =" is a GUC-setting command. If we have "SET var =" but the "var" is not a known GUC variable, don't offer any completions. The most likely explanation is that we've mispars

pgsql: Don't treat complete_from_const as equivalent to complete_from_l

2019-07-02 Thread Tom Lane
Don't treat complete_from_const as equivalent to complete_from_list. Commit 4f3b38fe2 supposed that complete_from_const() is equivalent to the one-element-list case of complete_from_list(), but that's not really true at all. complete_from_const() supposes that the completion is certain enough to

pgsql: Fix tab completion of "SET variable TO|=" to not offer bogus com

2019-07-02 Thread Tom Lane
Fix tab completion of "SET variable TO|=" to not offer bogus completions. Don't think that the context "UPDATE tab SET var =" is a GUC-setting command. If we have "SET var =" but the "var" is not a known GUC variable, don't offer any completions. The most likely explanation is that we've mispars

pgsql: Fix tab completion of "SET variable TO|=" to not offer bogus com

2019-07-02 Thread Tom Lane
Fix tab completion of "SET variable TO|=" to not offer bogus completions. Don't think that the context "UPDATE tab SET var =" is a GUC-setting command. If we have "SET var =" but the "var" is not a known GUC variable, don't offer any completions. The most likely explanation is that we've mispars

pgsql: Fix tab completion of "SET variable TO|=" to not offer bogus com

2019-07-02 Thread Tom Lane
Fix tab completion of "SET variable TO|=" to not offer bogus completions. Don't think that the context "UPDATE tab SET var =" is a GUC-setting command. If we have "SET var =" but the "var" is not a known GUC variable, don't offer any completions. The most likely explanation is that we've mispars

pgsql: Simplify psql \d's rule for ordering the indexes of a table.

2019-07-02 Thread Tom Lane
Simplify psql \d's rule for ordering the indexes of a table. The previous rule was "primary key (if any) first, then other unique indexes in name order, then all other indexes in name order". But the preference for unique indexes seems a bit obsolete since the introduction of exclusion constraints