Re: pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Tom Lane
Thomas Munro writes: > On Mon, Aug 19, 2019 at 11:01 AM Tom Lane wrote: >> Remove use of "register" keyword in hashfn.c. It's obsolescent >> according to recent C++ compilers, and no modern C compiler pays >> much attention to it either. > We have some more of those: > src/backend/regex/regexe

Re: pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Thomas Munro
On Mon, Aug 19, 2019 at 11:01 AM Tom Lane wrote: > Remove use of "register" keyword in hashfn.c. It's obsolescent > according to recent C++ compilers, and no modern C compiler pays > much attention to it either. We have some more of those: src/backend/regex/regexec.c src/common/md5.c src/includ

pgsql: Avoid conflicts with library versions of inet_net_ntop() and fri

2019-08-18 Thread Tom Lane
Avoid conflicts with library versions of inet_net_ntop() and friends. Prefix inet_net_ntop and sibling routines with "pg_" to ensure that they aren't mistaken for C-library functions. This fixes warnings from cpluspluscheck on some platforms, and should help reduce reader confusion everywhere, si

pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Tom Lane
Fix incidental warnings from cpluspluscheck. Remove use of "register" keyword in hashfn.c. It's obsolescent according to recent C++ compilers, and no modern C compiler pays much attention to it either. Also fix one cosmetic warning about signed vs unsigned comparison. Discussion: https://postgr

pgsql: Fix failure-to-compile-standalone in scripts_parallel.h.

2019-08-18 Thread Tom Lane
Fix failure-to-compile-standalone in scripts_parallel.h. Needs libpq-fe.h for references to PGConn. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5f110933e1145ad40116cf3c67a454cb6cb71cc2 Modified Fil

pgsql: Fix failure-to-compile-standalone in ecpg's dt.h.

2019-08-18 Thread Tom Lane
Fix failure-to-compile-standalone in ecpg's dt.h. This has to have , or the references to "struct tm" don't mean what they should. We have some other recently-introduced issues of the same ilk, but this one seems old. No backpatch though, as it's only a latent problem for most purposes. Branch

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co

pgsql: Disallow changing an inherited column's type if not all parents

2019-08-18 Thread Tom Lane
Disallow changing an inherited column's type if not all parents changed. If a table inherits from multiple unrelated parents, we must disallow changing the type of a column inherited from multiple such parents, else it would be out of step with the other parents. However, it's possible for the co