Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-25 Thread Michael Paquier
On Mon, Aug 26, 2019 at 02:17:06AM +, Michael Paquier wrote: > Fix error handling of vacuumdb and reindexdb when running out of fds > > When trying to use a high number of jobs, vacuumdb (and more recently > reindexdb) has only checked for a maximum number of jobs used, causing > confusing fai

pgsql: Fix error handling of vacuumdb when running out of fds

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb when running out of fds When trying to use a high number of jobs, vacuumdb has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error ha

pgsql: Fix error handling of vacuumdb when running out of fds

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb when running out of fds When trying to use a high number of jobs, vacuumdb has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error ha

pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb and reindexdb when running out of fds When trying to use a high number of jobs, vacuumdb (and more recently reindexdb) has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections t

pgsql: Fix error handling of vacuumdb when running out of fds

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb when running out of fds When trying to use a high number of jobs, vacuumdb has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error ha

pgsql: Fix error handling of vacuumdb when running out of fds

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb when running out of fds When trying to use a high number of jobs, vacuumdb has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error ha

pgsql: Fix error handling of vacuumdb when running out of fds

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb when running out of fds When trying to use a high number of jobs, vacuumdb has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error ha

Re: pgsql: Fix optimization of foreign-key on update actions

2019-08-25 Thread Peter Geoghegan
On Mon, Mar 18, 2019 at 9:21 AM Peter Eisentraut wrote: > Fix optimization of foreign-key on update actions It looks like datum_image_eq() doesn't handle the cstring case (i.e. the "typLen == -2" case) correctly. I think that it should. -- Peter Geoghegan

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Avoid platform-specific null pointer dereference in psql.

2019-08-25 Thread Tom Lane
Avoid platform-specific null pointer dereference in psql. POSIX permits getopt() to advance optind beyond argc when the last argv entry is an option that requires an argument and hasn't got one. It seems that no major platforms actually do that, but musl does, so that something like "psql -f" woul

pgsql: Back off output precision in circle.sql regression test.

2019-08-25 Thread Tom Lane
Back off output precision in circle.sql regression test. We were setting extra_float_digits = 0 to avoid platform-dependent output in this test, but that's still able to expose platform-specific roundoff behavior in some new test cases added by commit a3d284485, as reported by Peter Eisentraut. R

pgsql: Back off output precision in circle.sql regression test.

2019-08-25 Thread Tom Lane
Back off output precision in circle.sql regression test. We were setting extra_float_digits = 0 to avoid platform-dependent output in this test, but that's still able to expose platform-specific roundoff behavior in some new test cases added by commit a3d284485, as reported by Peter Eisentraut. R