pgsql: Fix thinko when ending progress report for a backend

2019-09-03 Thread Michael Paquier
Fix thinko when ending progress report for a backend The logic ending progress reporting for a backend entry introduced by b6fb647 causes callers of pgstat_progress_end_command() to do some extra work when track_activities is enabled as the process fields are reset in the backend entry even if no

pgsql: Fix thinko when ending progress report for a backend

2019-09-03 Thread Michael Paquier
Fix thinko when ending progress report for a backend The logic ending progress reporting for a backend entry introduced by b6fb647 causes callers of pgstat_progress_end_command() to do some extra work when track_activities is enabled as the process fields are reset in the backend entry even if no

pgsql: Fix thinko when ending progress report for a backend

2019-09-03 Thread Michael Paquier
Fix thinko when ending progress report for a backend The logic ending progress reporting for a backend entry introduced by b6fb647 causes callers of pgstat_progress_end_command() to do some extra work when track_activities is enabled as the process fields are reset in the backend entry even if no

pgsql: Fix thinko when ending progress report for a backend

2019-09-03 Thread Michael Paquier
Fix thinko when ending progress report for a backend The logic ending progress reporting for a backend entry introduced by b6fb647 causes callers of pgstat_progress_end_command() to do some extra work when track_activities is enabled as the process fields are reset in the backend entry even if no

pgsql: Fix thinko when ending progress report for a backend

2019-09-03 Thread Michael Paquier
Fix thinko when ending progress report for a backend The logic ending progress reporting for a backend entry introduced by b6fb647 causes callers of pgstat_progress_end_command() to do some extra work when track_activities is enabled as the process fields are reset in the backend entry even if no

pgsql: Delay fsyncs of pg_basebackup until the end of backup

2019-09-03 Thread Michael Paquier
Delay fsyncs of pg_basebackup until the end of backup Since the addition of fsync requests in bc34223 to make base backup data consistent on disk once pg_basebackup finishes, each tablespace tar file is individually flushed once completed, with an additional flush of the parent directory when the

pgsql: Delay fsyncs of pg_basebackup until the end of backup

2019-09-03 Thread Michael Paquier
Delay fsyncs of pg_basebackup until the end of backup Since the addition of fsync requests in bc34223 to make base backup data consistent on disk once pg_basebackup finishes, each tablespace tar file is individually flushed once completed, with an additional flush of the parent directory when the

pgsql: Delay fsyncs of pg_basebackup until the end of backup

2019-09-03 Thread Michael Paquier
Delay fsyncs of pg_basebackup until the end of backup Since the addition of fsync requests in bc34223 to make base backup data consistent on disk once pg_basebackup finishes, each tablespace tar file is individually flushed once completed, with an additional flush of the parent directory when the

pgsql: Delay fsyncs of pg_basebackup until the end of backup

2019-09-03 Thread Michael Paquier
Delay fsyncs of pg_basebackup until the end of backup Since the addition of fsync requests in bc34223 to make base backup data consistent on disk once pg_basebackup finishes, each tablespace tar file is individually flushed once completed, with an additional flush of the parent directory when the

pgsql: Make XLogReaderInvalReadState static

2019-09-03 Thread Alvaro Herrera
Make XLogReaderInvalReadState static This function is only used by xlogreader.c itself, so there's no need to export it. It was introduced by commit 3b02ea4f0780 with the apparent intention that it could be used externally, but I couldn't find any external code calling it. I (Álvaro) couldn't re

pgsql: Remove 'msg' parameter from convert_tuples_by_name

2019-09-03 Thread Alvaro Herrera
Remove 'msg' parameter from convert_tuples_by_name The message was included as a parameter when this function was added in dcb2bda9b704, but I don't think it has ever served any useful purpose. Let's stop spreading it pointlessly. Reviewed by Amit Langote and Peter Eisentraut. Discussion: https:

pgsql: Clarify pg_dump documentation

2019-09-03 Thread Peter Eisentraut
Clarify pg_dump documentation Clarify in the help output and documentation that -n, -t etc. take a "pattern" rather than a "schema" or "table" etc. This was especially confusing now that the new pg_dumpall --exclude-database option was documented with "pattern" and the others not, even though the

pgsql: Clarify pg_dump documentation

2019-09-03 Thread Peter Eisentraut
Clarify pg_dump documentation Clarify in the help output and documentation that -n, -t etc. take a "pattern" rather than a "schema" or "table" etc. This was especially confusing now that the new pg_dumpall --exclude-database option was documented with "pattern" and the others not, even though the

pgsql: Improve base backup protocol documentation

2019-09-03 Thread Peter Eisentraut
Improve base backup protocol documentation Document that the tablespace sizes are in units of kilobytes. Make the pg_basebackup source code a bit clearer about this, too. Reviewed-by: Magnus Hagander Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bde8c2d319ab3eb