pgsql: Avoid using INFO elevel for what are fundamentally debug message

2019-09-07 Thread Tom Lane
Avoid using INFO elevel for what are fundamentally debug messages. Commit 6f6b99d13 stuck an INFO message into the fast path for checking partition constraints, for no very good reason except that it made it easy for the regression tests to verify that that path was taken. Assorted later patches

pgsql: Avoid using INFO elevel for what are fundamentally debug message

2019-09-07 Thread Tom Lane
Avoid using INFO elevel for what are fundamentally debug messages. Commit 6f6b99d13 stuck an INFO message into the fast path for checking partition constraints, for no very good reason except that it made it easy for the regression tests to verify that that path was taken. Assorted later patches

pgsql: Fix issues around strictness of SIMILAR TO.

2019-09-07 Thread Tom Lane
Fix issues around strictness of SIMILAR TO. As a result of some long-ago quick hacks, the SIMILAR TO operator and the corresponding flavor of substring() interpreted "ESCAPE NULL" as selecting the default escape character '\'. This is both surprising and not per spec: the standard is clear that t

pgsql: Doc: make an editing pass over the v12 release notes.

2019-09-07 Thread Tom Lane
Doc: make an editing pass over the v12 release notes. Copy-edit or rewrite some items, add some items that I thought deserved documenting, remove some others that didn't (notably, I'm not on board with documenting documentation changes), fix some poorly-pointed links, move some items to other sect