pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro

2019-09-08 Thread Tom Lane
Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

2019-09-08 Thread Alexander Korotkov
Fix handling Inf and Nan values in GiST pairing heap comparator Previously plain float comparison was used in GiST pairing heap. Such comparison doesn't provide proper ordering for value sets containing Inf and Nan values. This commit fixes that by usage of float8_cmp_internal(). Note, there is

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: Fix handling of NULL distances in KNN-GiST

2019-09-08 Thread Alexander Korotkov
Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes

pgsql: configure: Update python search order

2019-09-08 Thread Tom Lane
configure: Update python search order Some systems don't ship with "python" by default anymore, only "python3" or "python2" or some combination, so include those in the configure search. Back-patch of commit 7291733ac. At the time that was only pushed back as far as v10, because of concerns abou

pgsql: configure: Update python search order

2019-09-08 Thread Tom Lane
configure: Update python search order Some systems don't ship with "python" by default anymore, only "python3" or "python2" or some combination, so include those in the configure search. Back-patch of commit 7291733ac. At the time that was only pushed back as far as v10, because of concerns abou

pgsql: configure: Update python search order

2019-09-08 Thread Tom Lane
configure: Update python search order Some systems don't ship with "python" by default anymore, only "python3" or "python2" or some combination, so include those in the configure search. Back-patch of commit 7291733ac. At the time that was only pushed back as far as v10, because of concerns abou

pgsql: Fix behavior of AND CHAIN outside of explicit transaction blocks

2019-09-08 Thread Peter Eisentraut
Fix behavior of AND CHAIN outside of explicit transaction blocks When using COMMIT AND CHAIN or ROLLBACK AND CHAIN not in an explicit transaction block, the previous implementation would leave a transaction block active in the ROLLBACK case but not the COMMIT case. To fix for now, error out when u

pgsql: Fix behavior of AND CHAIN outside of explicit transaction blocks

2019-09-08 Thread Peter Eisentraut
Fix behavior of AND CHAIN outside of explicit transaction blocks When using COMMIT AND CHAIN or ROLLBACK AND CHAIN not in an explicit transaction block, the previous implementation would leave a transaction block active in the ROLLBACK case but not the COMMIT case. To fix for now, error out when u

pgsql: doc: effective -> efficient

2019-09-08 Thread Peter Eisentraut
doc: effective -> efficient Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/422910423b6cba6abc3790b8f20854c9e78e04a4 Modified Files -- doc/src/sgml/json.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

pgsql: doc: effective -> efficient

2019-09-08 Thread Peter Eisentraut
doc: effective -> efficient Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0e777462121bd5b892c1621903d1953a49437290 Modified Files -- doc/src/sgml/json.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

pgsql: doc: Clean up title case use

2019-09-08 Thread Peter Eisentraut
doc: Clean up title case use Note: Following existing practice, titles of formalpara and step are not titlecased. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/eecd7c3d2b44094d00e967c7283fc2236d8def5d Modified Files -- doc/src/sgml/amcheck.sgml

pgsql: doc: Clean up title case use

2019-09-08 Thread Peter Eisentraut
doc: Clean up title case use Note: Following existing practice, titles of formalpara and step are not titlecased. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e929a4667a1f4f97c5447f54b8176b0ee15aa7d Modified Files -- doc/src/sgml/amcheck.sgml