pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix nbtree page split rmgr desc routine.

2019-09-12 Thread Peter Geoghegan
Fix nbtree page split rmgr desc routine. Include newitemoff in rmgr desc output for nbtree page split records. In passing, correct an obsolete comment that claimed that newitemoff is only logged for _L variant nbtree page split WAL records. Both issues were oversights in commit 2c03216d831, which

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Fix usage of whole-row variables in WCO and RLS policy expressio

2019-09-12 Thread Tom Lane
Fix usage of whole-row variables in WCO and RLS policy expressions. Since WITH CHECK OPTION was introduced, ExecInitModifyTable has initialized WCO expressions with the wrong plan node as parent -- that is, it passed its input subplan not the ModifyTable node itself. Up to now we thought this was

pgsql: Improve documentation about our XML functionality

2019-09-12 Thread Alvaro Herrera
Improve documentation about our XML functionality Add a section explaining how our XML features depart from current versions of the SQL standard. Update and clarify the descriptions of some XML functions. This is a backpatch for branches 10 and 11, taken from Tom's commit 12d46ac392d0 for 12, th

pgsql: Improve documentation about our XML functionality

2019-09-12 Thread Alvaro Herrera
Improve documentation about our XML functionality Add a section explaining how our XML features depart from current versions of the SQL standard. Update and clarify the descriptions of some XML functions. This is a backpatch for branches 10 and 11, taken from Tom's commit 12d46ac392d0 for 12, th

pgsql: Reorder two nbtree.h function prototypes.

2019-09-12 Thread Peter Geoghegan
Reorder two nbtree.h function prototypes. Make the function prototype order consistent with the definition order in nbtinsert.c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/614cdeaa8908f69ab0b97b688e9785147575c01f Modified Files -- src/include/acces

pgsql: Remove redundant _bt_truncate() comment paragraph.

2019-09-12 Thread Peter Geoghegan
Remove redundant _bt_truncate() comment paragraph. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b9becd43ccb7d48243882c021738c60d32c55aa Modified Files -- src/backend/access/nbtree/nbtutils.c | 21 - 1 file changed, 8 insertions(+),

pgsql: Merge two assertions to make comment clearer

2019-09-12 Thread Alvaro Herrera
Merge two assertions to make comment clearer Authored by Tom Lane, after a gripe from James Coleman. Discussion: https://postgr.es/m/CAAaqYe9GD__4Crm=ddz+-XXcNhfY_V5gFYdLdmkFNq=2vho...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc98e1ea64627183

pgsql: Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and

2019-09-12 Thread Alexander Korotkov
Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and 10 9ee98cc3f added missing doc for pg_trgm.strict_word_similarity_threshold GUC. But it was accidentally backpatched to 9.6, while this GUC was introduced only in 11. This patch removes extra doc from 9.6 and 10. Discussion: https

pgsql: Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and

2019-09-12 Thread Alexander Korotkov
Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and 10 9ee98cc3f added missing doc for pg_trgm.strict_word_similarity_threshold GUC. But it was accidentally backpatched to 9.6, while this GUC was introduced only in 11. This patch removes extra doc from 9.6 and 10. Discussion: https

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In

pgsql: Doc: Update PL/pgSQL sample function in plpgsql.sgml.

2019-09-12 Thread Amit Kapila
Doc: Update PL/pgSQL sample function in plpgsql.sgml. The example used to explain 'Looping Through Query Results' uses pseudo-materialized views. Replace it with a more up-to-date example which does the same thing with actual materialized views, which have been available since PostgreSQL 9.3. In