pgsql: Add tab completion for EXPLAIN (SETTINGS) in psql

2019-09-26 Thread Michael Paquier
Add tab completion for EXPLAIN (SETTINGS) in psql Author: Justin Pryzby Reviewed-by: Tatsuro Yamada Discussion: https://postgr.es/m/20190927022051.gc24...@telsasoft.com Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b011cad272e997935eb8d80ab7

pgsql: Add tab completion for EXPLAIN (SETTINGS) in psql

2019-09-26 Thread Michael Paquier
Add tab completion for EXPLAIN (SETTINGS) in psql Author: Justin Pryzby Reviewed-by: Tatsuro Yamada Discussion: https://postgr.es/m/20190927022051.gc24...@telsasoft.com Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/268c4e9d4d88f5b4baca

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

pgsql: Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252

2019-09-26 Thread Amit Kapila
Fix oversight in commit 4429f6a9e3e12bb4af6e3677fbc78cd80f160252. The test name and the following test cases suggest the index created should be hash index, but it forgot to add 'using hash' in the test case. This in itself won't improve code coverage as there were some other tests which were cove

Re: pgsql: Support reloptions of enum type

2019-09-26 Thread Michael Paquier
On Thu, Sep 26, 2019 at 10:19:47PM -0300, Alvaro Herrera wrote: > Thanks for fixing. It all looks correct to me. Thanks for double-checking. -- Michael signature.asc Description: PGP signature

Re: pgsql: Support reloptions of enum type

2019-09-26 Thread Alvaro Herrera
Hello, sorry I didn't notice this email. On 2019-Sep-26, Michael Paquier wrote: > This part from commit 773df88 is incorrect: > + /* > +* Set the default lock mode for this option. There is no actual way > +* for a module to enforce it when declaring a custom relation option, > +*

Re: pgsql: Support reloptions of enum type

2019-09-26 Thread Michael Paquier
On Thu, Sep 26, 2019 at 08:41:52AM +0900, Michael Paquier wrote: > Do you mind if I apply the attached to fix the issue? Or perhaps you > would prefer fixing the issue yourself? I noted some inconsistencies > with the rest while on it (please see attached). And applied as of fbfa566. -- Michael

pgsql: Fix lockmode initialization for custom relation options

2019-09-26 Thread Michael Paquier
Fix lockmode initialization for custom relation options The code was enforcing AccessExclusiveLock for all custom relation options, which is incorrect as the APIs allow a custom lock level to be set. While on it, fix a couple of inconsistencies in the tests and the README of dummy_index_am. Over

pgsql: doc: Fix whitespace in markup

2019-09-26 Thread Peter Eisentraut
doc: Fix whitespace in markup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8190164e82ae03bde80864ab0941794a90e70483 Modified Files -- doc/src/sgml/func.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: doc: Format example JSON data better

2019-09-26 Thread Peter Eisentraut
doc: Format example JSON data better Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/79504cfe1b23cd22c78dd5786f81f40905c5cce0 Modified Files -- doc/src/sgml/func.sgml | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

pgsql: doc: Format example JSON data better

2019-09-26 Thread Peter Eisentraut
doc: Format example JSON data better Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c3ef7482f2bdedc68146a4ffcba4b8b241b91a9 Modified Files -- doc/src/sgml/func.sgml | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

pgsql: doc: Fix whitespace in markup

2019-09-26 Thread Peter Eisentraut
doc: Fix whitespace in markup Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d10475a0433291bfd136df6edb06497af0f52cb8 Modified Files -- doc/src/sgml/func.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: doc: Update a confusing sentence about SQL/JSON

2019-09-26 Thread Peter Eisentraut
doc: Update a confusing sentence about SQL/JSON Author: Liudmila Mantrova Reported-by: Jeff Janes Discussion: https://www.postgresql.org/message-id/flat/CAMkU%3D1wP-SO4KpiLxHJuPezTJCmK%3DJqefLXrr3eXFO7Qku%2BtMg%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/p

pgsql: doc: Update a confusing sentence about SQL/JSON

2019-09-26 Thread Peter Eisentraut
doc: Update a confusing sentence about SQL/JSON Author: Liudmila Mantrova Reported-by: Jeff Janes Discussion: https://www.postgresql.org/message-id/flat/CAMkU%3D1wP-SO4KpiLxHJuPezTJCmK%3DJqefLXrr3eXFO7Qku%2BtMg%40mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresq

pgsql: doc: Update note about source code formatting

2019-09-26 Thread Peter Eisentraut
doc: Update note about source code formatting Update the note about why not to use // comments, even though it's now technically supported. The note about variable declarations was dropped here because it's addressed more properly later in the chapter. Discussion: https://www.postgresql.org/mes

pgsql: doc: Update note about source code formatting

2019-09-26 Thread Peter Eisentraut
doc: Update note about source code formatting Update the note about why not to use // comments, even though it's now technically supported. The note about variable declarations was dropped here because it's addressed more properly later in the chapter. Discussion: https://www.postgresql.org/mes

pgsql: doc: Reorder JSON functions documentation

2019-09-26 Thread Peter Eisentraut
doc: Reorder JSON functions documentation Put the description of the SQL/JSON path language after the description of the general JSON functions and operators, instead of before. Discussion: https://www.postgresql.org/message-id/16968.1569189...@sss.pgh.pa.us Branch -- master Details ---

pgsql: doc: Reorder JSON functions documentation

2019-09-26 Thread Peter Eisentraut
doc: Reorder JSON functions documentation Put the description of the SQL/JSON path language after the description of the general JSON functions and operators, instead of before. Discussion: https://www.postgresql.org/message-id/16968.1569189...@sss.pgh.pa.us Branch -- REL_12_STABLE Details