pgsql: Fix table rewrites that include a column without a default.

2019-10-09 Thread Andres Freund
Fix table rewrites that include a column without a default. In c2fe139c201c I made ATRewriteTable() use tuple slots. Unfortunately I did not notice that columns can be added in a rewrite that do not have a default, when another column is added/altered requiring one. Initialize columns to NULL aga

pgsql: Fix table rewrites that include a column without a default.

2019-10-09 Thread Andres Freund
Fix table rewrites that include a column without a default. In c2fe139c201c I made ATRewriteTable() use tuple slots. Unfortunately I did not notice that columns can be added in a rewrite that do not have a default, when another column is added/altered requiring one. Initialize columns to NULL aga

pgsql: Revert "Use libc version as a collation version on glibc systems

2019-10-09 Thread Peter Eisentraut
Revert "Use libc version as a collation version on glibc systems." This reverts commit 9f90b1d08d796a925808b24f77f624a0ff682c77. This needs some refinements in the pg_dump and pg_upgrade tests. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/50518ec296aea3af3e00c43

pgsql: Use libc version as a collation version on glibc systems.

2019-10-09 Thread Peter Eisentraut
Use libc version as a collation version on glibc systems. Using glibc's version number to detect potential collation definition changes is not 100% reliable, but it's better than nothing. Author: Thomas Munro Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/4b76c6d4-ae5e-0dc6-7d0d-b