pgsql: Make crash recovery ignore restore_command and recovery_end_comm

2019-10-10 Thread Fujii Masao
Make crash recovery ignore restore_command and recovery_end_command settings. In v11 or before, those settings could not take effect in crash recovery because they are specified in recovery.conf and crash recovery always starts without recovery.conf. But commit 2dedf4d9a8 integrated recovery.conf

pgsql: Make crash recovery ignore restore_command and recovery_end_comm

2019-10-10 Thread Fujii Masao
Make crash recovery ignore restore_command and recovery_end_command settings. In v11 or before, those settings could not take effect in crash recovery because they are specified in recovery.conf and crash recovery always starts without recovery.conf. But commit 2dedf4d9a8 integrated recovery.conf

Re: pgsql: Fix table rewrites that include a column without a default.

2019-10-10 Thread Tom Lane
Andres Freund writes: > On 2019-10-10 16:51:23 -0400, Tom Lane wrote: >> Do you *really* need an event trigger to test this? > No. I added it to avoid the tests getting "accidentally" optimized away, > the next time somebody adds some ALTER TABLE optimizations. The fast > default stuff had remove

Re: pgsql: Fix table rewrites that include a column without a default.

2019-10-10 Thread Andres Freund
Hi, On 2019-10-10 16:51:23 -0400, Tom Lane wrote: > Andres Freund writes: > > Fix table rewrites that include a column without a default. > > This patch added use of an event trigger in alter_table.sql. > As we have learned the hard way, it's not acceptable to create event > triggers in test scr

Re: pgsql: Fix table rewrites that include a column without a default.

2019-10-10 Thread Tom Lane
Andres Freund writes: > Fix table rewrites that include a column without a default. This patch added use of an event trigger in alter_table.sql. As we have learned the hard way, it's not acceptable to create event triggers in test scripts that run in parallel with anything else, because they will

pgsql: Put back pqsignal() as an exported libpq symbol.

2019-10-10 Thread Tom Lane
Put back pqsignal() as an exported libpq symbol. This reverts commit f7ab80285. Per discussion, we can't remove an exported symbol without a SONAME bump, which we don't want to do. In particular that breaks usage of current libpq.so with pre-9.3 versions of psql etc, which need libpq to export pq

pgsql: Put back pqsignal() as an exported libpq symbol.

2019-10-10 Thread Tom Lane
Put back pqsignal() as an exported libpq symbol. This reverts commit f7ab80285. Per discussion, we can't remove an exported symbol without a SONAME bump, which we don't want to do. In particular that breaks usage of current libpq.so with pre-9.3 versions of psql etc, which need libpq to export pq

pgsql: pg_upgrade: Clean up some redundant code

2019-10-10 Thread Peter Eisentraut
pg_upgrade: Clean up some redundant code No need to call exit() after pg_fatal(). Clean up a few stragglers for consistency. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3b5d3721c25ed1270832265c5475649c3baa0e26 Modified Files -- src/bin/pg_upgrade/o