Re: pgsql: Fix dependency handling of column drop with partitioned tables

2019-10-14 Thread Michael Paquier
On Sun, Oct 13, 2019 at 04:29:10PM -0400, Tom Lane wrote: > Yeah, that sounds good to me. Thanks, I have just committed a fix doing that. -- Michael signature.asc Description: PGP signature

pgsql: Correct reference to pg_catalog.regtype in pg_upgrade query

2019-10-14 Thread Tomas Vondra
Correct reference to pg_catalog.regtype in pg_upgrade query The recursive CTE added in 0ccfc28223 referenced pg_catalog.regtype, without the schema part, unlike all other queries in pg_upgrade. Backpatch-to: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Correct reference to pg_catalog.regtype in pg_upgrade query

2019-10-14 Thread Tomas Vondra
Correct reference to pg_catalog.regtype in pg_upgrade query The recursive CTE added in 0ccfc28223 referenced pg_catalog.regtype, without the schema part, unlike all other queries in pg_upgrade. Backpatch-to: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3a0e85

pgsql: Check for tables with sql_identifier during pg_upgrade

2019-10-14 Thread Tomas Vondra
Check for tables with sql_identifier during pg_upgrade Commit 7c15cef86d changed sql_identifier data type to be based on name instead of varchar. Unfortunately, this breaks on-disk format for this data type. Luckily, that should be a very rare problem, as this data type is used only in informati

pgsql: Check for tables with sql_identifier during pg_upgrade

2019-10-14 Thread Tomas Vondra
Check for tables with sql_identifier during pg_upgrade Commit 7c15cef86d changed sql_identifier data type to be based on name instead of varchar. Unfortunately, this breaks on-disk format for this data type. Luckily, that should be a very rare problem, as this data type is used only in informati

pgsql: Update test output of sepgsql for ALTER TABLE COLUMN DROP

2019-10-14 Thread Michael Paquier
Update test output of sepgsql for ALTER TABLE COLUMN DROP 1df5875 has changed the way dependencies are dropped for this command with inheritance trees, which impacts sepgsql. This just updates the regression test output to take care of the failures and adapt to the new code. Reported by buildfar

pgsql: In the postmaster, rely on the signal infrastructure to block si

2019-10-14 Thread Tom Lane
In the postmaster, rely on the signal infrastructure to block signals. POSIX sigaction(2) can be told to block a set of signals while a signal handler executes. Make use of that instead of manually blocking and unblocking signals in the postmaster's signal handlers. This should save a few cycles,

pgsql: Fix dependency handling of column drop with partitioned tables

2019-10-14 Thread Michael Paquier
Fix dependency handling of column drop with partitioned tables When dropping a column on a partitioned table which has one or more partitioned indexes, the operation was failing as dependencies with partitioned indexes using the column dropped were not getting removed in a way consistent with the

pgsql: Fix dependency handling of column drop with partitioned tables

2019-10-14 Thread Michael Paquier
Fix dependency handling of column drop with partitioned tables When dropping a column on a partitioned table which has one or more partitioned indexes, the operation was failing as dependencies with partitioned indexes using the column dropped were not getting removed in a way consistent with the

pgsql: Update test output of sepgsql for ALTER TABLE COLUMN DROP

2019-10-14 Thread Michael Paquier
Update test output of sepgsql for ALTER TABLE COLUMN DROP 1df5875 has changed the way dependencies are dropped for this command with inheritance trees, which impacts sepgsql. This just updates the regression test output to take care of the failures and adapt to the new code. Reported by buildfar