Re: pgsql: Make the order of the header file includes consistent in non-bac

2019-10-25 Thread Michael Paquier
On Fri, Oct 25, 2019 at 03:21:13PM +0530, Amit Kapila wrote: > Reverted and the buildfarm is green again. Thanks! Thanks for fixing, and the follow-up thread. (Just saw the rest as well.) -- Michael signature.asc Description: PGP signature

pgsql: Remove obsolete information schema tables

2019-10-25 Thread Peter Eisentraut
Remove obsolete information schema tables Remove SQL_LANGUAGES, which was eliminated in SQL:2008, and SQL_PACKAGES and SQL_SIZING_PROFILES, which were eliminated in SQL:2011. Since they were dropped by the SQL standard, the information in them was no longer updated and therefore no longer useful.

pgsql: Avoid failure when selecting a namespace node in XMLTABLE.

2019-10-25 Thread Tom Lane
Avoid failure when selecting a namespace node in XMLTABLE. It appears that libxml2 doesn't bother to set the "children" field of an XML_NAMESPACE_DECL node to null; that field just contains garbage. In v10 and v11, this can result in a crash in XMLTABLE(). The rewrite done in commit 251cf2e27 fix

pgsql: Avoid failure when selecting a namespace node in XMLTABLE.

2019-10-25 Thread Tom Lane
Avoid failure when selecting a namespace node in XMLTABLE. It appears that libxml2 doesn't bother to set the "children" field of an XML_NAMESPACE_DECL node to null; that field just contains garbage. In v10 and v11, this can result in a crash in XMLTABLE(). The rewrite done in commit 251cf2e27 fix

pgsql: Avoid failure when selecting a namespace node in XMLTABLE.

2019-10-25 Thread Tom Lane
Avoid failure when selecting a namespace node in XMLTABLE. It appears that libxml2 doesn't bother to set the "children" field of an XML_NAMESPACE_DECL node to null; that field just contains garbage. In v10 and v11, this can result in a crash in XMLTABLE(). The rewrite done in commit 251cf2e27 fix

pgsql: Avoid failure when selecting a namespace node in XMLTABLE.

2019-10-25 Thread Tom Lane
Avoid failure when selecting a namespace node in XMLTABLE. It appears that libxml2 doesn't bother to set the "children" field of an XML_NAMESPACE_DECL node to null; that field just contains garbage. In v10 and v11, this can result in a crash in XMLTABLE(). The rewrite done in commit 251cf2e27 fix

pgsql: doc: Use proper em and en dashes

2019-10-25 Thread Peter Eisentraut
doc: Use proper em and en dashes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbe63d02d0f7d85ecbae7d8998f5edfe56d50b9d Modified Files -- doc/src/sgml/biblio.sgml | 6 ++-- doc/src/sgml/bki.sgml | 4 +-- doc/src/sgml/brin.s

pgsql: Revert "Revert part of commit dddf4cdc3."

2019-10-25 Thread Tom Lane
Revert "Revert part of commit dddf4cdc3." This reverts commit c114229ca2519620703a4be4e38181290cad8c0a. Commit 1408d5d869925c8ea7ca01c2644e8903fbab23de should make it safe to include these headers in the natural order. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Get rid of useless/dangerous redefinition of bool in ECPG.

2019-10-25 Thread Tom Lane
Get rid of useless/dangerous redefinition of bool in ECPG. pgtypeslib_extern.h contained fallback definitions of "bool", "FALSE", and "TRUE". The latter two are just plain unused, and have been for awhile. The former came into play only if there wasn't a macro definition of "bool", which is true

pgsql: Get rid of useless/dangerous redefinition of bool in ECPG.

2019-10-25 Thread Tom Lane
Get rid of useless/dangerous redefinition of bool in ECPG. pgtypeslib_extern.h contained fallback definitions of "bool", "FALSE", and "TRUE". The latter two are just plain unused, and have been for awhile. The former came into play only if there wasn't a macro definition of "bool", which is true

pgsql: Reset statement_timeout between queries of a multi-query string.

2019-10-25 Thread Tom Lane
Reset statement_timeout between queries of a multi-query string. Historically, we started the timer (if StatementTimeout > 0) at the beginning of a simple-Query message and usually let it run until the end, so that the timeout limit applied to the entire query string, and intra-string changes of t

pgsql: Improve management of statement timeouts.

2019-10-25 Thread Tom Lane
Improve management of statement timeouts. Commit f8e5f156b added private state in postgres.c to track whether a statement timeout is running. This seems like bad design to me; timeout.c's private state should be the single source of truth about that. We already fixed one bug associated with fail

Re: pgsql: Make the order of the header file includes consistent in non-bac

2019-10-25 Thread Amit Kapila
On Fri, Oct 25, 2019 at 11:47 AM Michael Paquier wrote: > > On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote: > > One possible reason could be that pgtypeslib_extern.h has define like below: > > #ifndef bool > > #define bool char > > #endif /* ndef bool */ > > Possible. I have not look

Re: pgsql: Make the order of the header file includes consistent in non-bac

2019-10-25 Thread Amit Kapila
On Fri, Oct 25, 2019 at 1:30 PM Andrew Gierth wrote: > > > "Amit" == Amit Kapila writes: > > Amit> BTW, prairiedog is also show similar failure and both seems to > Amit> have similar OS except for versions. > > Be aware that prairiedog and locust (unlike the rest of the buildfarm) > have co

Re: pgsql: Make the order of the header file includes consistent in non-bac

2019-10-25 Thread Andrew Gierth
> "Amit" == Amit Kapila writes: Amit> BTW, prairiedog is also show similar failure and both seems to Amit> have similar OS except for versions. Be aware that prairiedog and locust (unlike the rest of the buildfarm) have compilers whose "bool" type is not 1 byte long; PG can't use that, so