pgsql: Fix initialization of fake LSN for unlogged relations

2019-10-26 Thread Michael Paquier
Fix initialization of fake LSN for unlogged relations 9155580 has changed the value of the first fake LSN for unlogged relations from 1 to FirstNormalUnloggedLSN (aka 1000), GiST requiring a non-zero LSN on some pages to allow an interlocking logic to work, but its value was still initialized to 1

pgsql: Fix initialization of fake LSN for unlogged relations

2019-10-26 Thread Michael Paquier
Fix initialization of fake LSN for unlogged relations 9155580 has changed the value of the first fake LSN for unlogged relations from 1 to FirstNormalUnloggedLSN (aka 1000), GiST requiring a non-zero LSN on some pages to allow an interlocking logic to work, but its value was still initialized to 1

Re: pgsql: Fix copy-paste defect in comment.

2019-10-26 Thread Michael Paquier
On Sat, Oct 26, 2019 at 07:57:14PM +, Noah Misch wrote: > Fix copy-paste defect in comment. > > Commit a7471bd85c05f849e88d6cfe9da3c795008e8f2e introduced it. Thanks, Noah. -- Michael signature.asc Description: PGP signature

pgsql: Fix pg_dump's handling of circular dependencies in views.

2019-10-26 Thread Tom Lane
Fix pg_dump's handling of circular dependencies in views. This is a back-patch of the v10 commit d8c05aff5. The motivation for doing this now is that we received a complaint that a view with a circular dependency is dumped with an extra bogus command "ALTER TABLE ONLY myview REPLICA IDENTITY NOTH

pgsql: Fix pg_dump's handling of circular dependencies in views.

2019-10-26 Thread Tom Lane
Fix pg_dump's handling of circular dependencies in views. This is a back-patch of the v10 commit d8c05aff5. The motivation for doing this now is that we received a complaint that a view with a circular dependency is dumped with an extra bogus command "ALTER TABLE ONLY myview REPLICA IDENTITY NOTH

pgsql: Fix pg_dump's handling of circular dependencies in views.

2019-10-26 Thread Tom Lane
Fix pg_dump's handling of circular dependencies in views. This is a back-patch of the v10 commit d8c05aff5. The motivation for doing this now is that we received a complaint that a view with a circular dependency is dumped with an extra bogus command "ALTER TABLE ONLY myview REPLICA IDENTITY NOTH

pgsql: Fix copy-paste defect in comment.

2019-10-26 Thread Noah Misch
Fix copy-paste defect in comment. Commit a7471bd85c05f849e88d6cfe9da3c795008e8f2e introduced it. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b804521344fb366215900ac3f01314a1710bc6d8 Modified Files -- src/include/c.h | 2 +- 1 file changed, 1 insertio

pgsql: Update comment about __sync_lock_test_and_set() bug.

2019-10-26 Thread Noah Misch
Update comment about __sync_lock_test_and_set() bug. State the earliest known fixed version, so we can someday judge the workaround to be obsolete. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e653c714c25bb8bde0b80b3bf3a220704b71a106 Modified Files -

pgsql: Doc: improve documentation of configuration settings that have u

2019-10-26 Thread Tom Lane
Doc: improve documentation of configuration settings that have units. When we added the GUC units feature, we didn't make any great effort to adjust the documentation of individual GUCs; they tended to still say things like "this is the number of milliseconds that ...", even though users might pre

pgsql: Doc: improve documentation of configuration settings that have u

2019-10-26 Thread Tom Lane
Doc: improve documentation of configuration settings that have units. When we added the GUC units feature, we didn't make any great effort to adjust the documentation of individual GUCs; they tended to still say things like "this is the number of milliseconds that ...", even though users might pre