pgsql: Add regression test for two-phase transaction in postgres_fdw

2019-11-12 Thread Michael Paquier
Add regression test for two-phase transaction in postgres_fdw postgres_fdw does not support two-phase transactions, so let's add a small negative test case to check after it. Note that this is checked using an end-of-xact callback to ensure a proper connection cleanup with the foreign server, whi

pgsql: docs: clarify that only INSERT and UPDATE triggers can mod. NEW

2019-11-12 Thread Bruce Momjian
docs: clarify that only INSERT and UPDATE triggers can mod. NEW The point is that DELETE triggers cannot modify any values. Reported-by: Eugen Konkov, Liudmila Mantrova Discussion: https://postgr.es/m/[email protected] Backpatch-through: 12 only, where commit as missing Branc

pgsql: Introduce the 'force' option for the Drop Database command.

2019-11-12 Thread Amit Kapila
Introduce the 'force' option for the Drop Database command. This new option terminates the other sessions connected to the target database and then drop it. To terminate other sessions, the current user must have desired permissions (same as pg_terminate_backend()). We don't allow to terminate t

pgsql: Tag refs/tags/REL_10_11 was created

2019-11-12 Thread noreply
Tag refs/tags/REL_10_11 was created.

pgsql: Tag refs/tags/REL9_5_20 was created

2019-11-12 Thread noreply
Tag refs/tags/REL9_5_20 was created.

pgsql: Tag refs/tags/REL9_4_25 was created

2019-11-12 Thread noreply
Tag refs/tags/REL9_4_25 was created.

pgsql: Tag refs/tags/REL_11_6 was created

2019-11-12 Thread noreply
Tag refs/tags/REL_11_6 was created.

pgsql: Tag refs/tags/REL9_6_16 was created

2019-11-12 Thread noreply
Tag refs/tags/REL9_6_16 was created.

pgsql: Tag refs/tags/REL_12_1 was created

2019-11-12 Thread noreply
Tag refs/tags/REL_12_1 was created.

pgsql: Finish reverting commit 0a52d378b.

2019-11-12 Thread Tom Lane
Finish reverting commit 0a52d378b. Apply the solution adopted in commit dcb7d3caf (ie, explicitly don't call memcmp for a zero-length comparison) to func_get_detail() as well, removing one other place where we were passing an uninitialized array to a parse_func.c entry point. Discussion: https:/

pgsql: pg_stat_{ssl,gssapi}: Show only processes with connections

2019-11-12 Thread Alvaro Herrera
pg_stat_{ssl,gssapi}: Show only processes with connections It is pointless to show in those views auxiliary processes that don't open network connections. A small incompatibility is that anybody joining pg_stat_activity and pg_stat_ssl/pg_stat_gssapi will have to use a left join if they want to s

pgsql: pg_stat_activity: document client_port being null

2019-11-12 Thread Alvaro Herrera
pg_stat_activity: document client_port being null As suggested by Stephen Frost. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c5e8ea978d88ea4aa731516836e14d54c50cc957 Modified Files --

pgsql: Make _bt_keep_natts_fast() use datum_image_eq().

2019-11-12 Thread Peter Geoghegan
Make _bt_keep_natts_fast() use datum_image_eq(). An upcoming patch that adds deduplication to the nbtree AM will rely on _bt_keep_natts_fast() understanding that differences in TOAST input state can never affect its answer. In particular, two opclass-equal datums (with opclasses deemed safe for d

pgsql: Have LookupFuncName accept NULL argtypes for 0 args

2019-11-12 Thread Alvaro Herrera
Have LookupFuncName accept NULL argtypes for 0 args Prior to this change, it requires to be passed a valid pointer just to be able to pass it to a zero-byte memcmp, per 0a52d378b03b. Given the strange resulting code in callsites, it seems better to test for the case specifically and remove the re

pgsql: Teach datum_image_eq() about cstring datums.

2019-11-12 Thread Peter Geoghegan
Teach datum_image_eq() about cstring datums. Bring datum_image_eq() in line with datumIsEqual() by adding support for comparing cstring datums. An upcoming patch that adds deduplication to the nbtree AM will use datum_image_eq(). datum_image_eq() will need to work with all datatypes that can be

pgsql: Fix ecpglib.h to declare bool consistently with c.h.

2019-11-12 Thread Tom Lane
Fix ecpglib.h to declare bool consistently with c.h. This completes the task begun in commit 1408d5d86, to synchronize ECPG's exported definitions with the definition of bool used by c.h (and, therefore, the one actually in use in the ECPG library). On practically all modern platforms, ecpglib.h w

Re: pgsql: Make the order of the header file includes consistent in backend

2019-11-12 Thread Amit Kapila
On Tue, Nov 12, 2019 at 8:33 AM Amit Kapila wrote: > > Make the order of the header file includes consistent in backend modules. > I see two buildfarm failures at this commit, but none seems to related to this change. 1. The failure of anole seems to have happened earlier as well. https://buildf

Re: pgsql: gitattributes: Add new file

2019-11-12 Thread Michael Paquier
On Tue, Nov 12, 2019 at 07:15:43AM +, Peter Eisentraut wrote: > gitattributes: Add new file Missed that spot, thanks! -- Michael signature.asc Description: PGP signature