pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Further fix dumping of views that contain just VALUES(...).

2019-11-16 Thread Tom Lane
Further fix dumping of views that contain just VALUES(...). It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause wo

pgsql: Add tuplesort test to serial_schedule.

2019-11-16 Thread Peter Geoghegan
Add tuplesort test to serial_schedule. Oversight in commit 4a252996. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/815bd578076672a2325d026a2c48b6075454be9b Modified Files -- src/test/regress/serial_schedule | 1 + 1 file changed, 1 insertion(+)

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Peter Geoghegan
On Sat, Nov 16, 2019 at 10:14 AM Andres Freund wrote: > Indeed, thanks for catching. I'm off till Monday... If you want to push the > addition... No problem. I'll push a fix now. -- Peter Geoghegan

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Andres Freund
Hi, On November 16, 2019 10:09:19 AM PST, Peter Geoghegan wrote: >On Wed, Nov 13, 2019 at 4:09 PM Andres Freund >wrote: >> Add tests for tuplesort.c. > >> Modified Files >> -- >> src/test/regress/expected/tuplesort.out | 691 > >> src/test/regress/para

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Peter Geoghegan
On Wed, Nov 13, 2019 at 4:09 PM Andres Freund wrote: > Add tests for tuplesort.c. > Modified Files > -- > src/test/regress/expected/tuplesort.out | 691 > src/test/regress/parallel_schedule | 2 +- > src/test/regress/sql/tuplesort.sql | 304 +