pgsql: Disallow dropping rules on system tables by default

2019-12-19 Thread Peter Eisentraut
Disallow dropping rules on system tables by default This was previously not covered by allow_system_table_mods, but now it is. The impact in practice is probably low, but this makes it consistent with most other DDL commands. Reviewed-by: Robert Haas Discussion: https://www.postgresql.org/mess

pgsql: Fix compiler warnings on MSYS2

2019-12-19 Thread Peter Eisentraut
Fix compiler warnings on MSYS2 The PS_USE_NONE case in ps_status.c left a couple of unused variables exposed. Discussion: https://www.postgresql.org/message-id/flat/6b467edc-4018-521f-ab18-171f098557ca%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: Superuser can permit passwordless connections on postgres_fdw

2019-12-19 Thread Andrew Dunstan
Superuser can permit passwordless connections on postgres_fdw Currently postgres_fdw doesn't permit a non-superuser to connect to a foreign server without specifying a password, or to use an authentication mechanism that doesn't use the password. This is to avoid using the settings and identity of

pgsql: Extend the ProcSignal mechanism to support barriers.

2019-12-19 Thread Robert Haas
Extend the ProcSignal mechanism to support barriers. A new function EmitProcSignalBarrier() can be used to emit a global barrier which all backends that participate in the ProcSignal mechanism must absorb, and a new function WaitForProcSignalBarrier() can be used to wait until all relevant backend

pgsql: Remove unneeded "pin scan" nbtree VACUUM code.

2019-12-19 Thread Peter Geoghegan
Remove unneeded "pin scan" nbtree VACUUM code. The REDO routine for nbtree's xl_btree_vacuum record type hasn't performed a "pin scan" since commit 3e4b7d87 went in, so clearly there isn't any point in VACUUM WAL-logging information that won't actually be used. Finish off the work of commit 3e4b7

pgsql: revert: Remove meaningless assignments in nbtree code

2019-12-19 Thread Bruce Momjian
revert: Remove meaningless assignments in nbtree code Reverts commit 05684c8255. Reported-by: Tom Lane Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b93e9a5c94b4c89932a63779

pgsql: Remove meaningless assignments in nbtree code

2019-12-19 Thread Bruce Momjian
Remove meaningless assignments in nbtree code Reported-by: Ranier Vilela Discussion: https://postgr.es/m/mn2pr18mb2927bb876d12a70fdbe8f35ae3...@mn2pr18mb2927.namprd18.prod.outlook.com Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05684

pgsql: makeArrayTypeName: Remove pointless relation open/close

2019-12-19 Thread Alvaro Herrera
makeArrayTypeName: Remove pointless relation open/close Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2b93e3d96b941740877b2ae196511564e5cc989b Modified Files -- src/backend/catalog/

pgsql: Doc: add a short summary of available authentication methods.

2019-12-19 Thread Tom Lane
Doc: add a short summary of available authentication methods. The "auth-methods" used to include descriptions of all our authentication methods. Commit 56811e573 promoted its child 's to 's, which has advantages but also created some issues: * The auth-methods page itself is essentially empty/us

pgsql: Doc: add a short summary of available authentication methods.

2019-12-19 Thread Tom Lane
Doc: add a short summary of available authentication methods. The "auth-methods" used to include descriptions of all our authentication methods. Commit 56811e573 promoted its child 's to 's, which has advantages but also created some issues: * The auth-methods page itself is essentially empty/us

pgsql: Doc: add a short summary of available authentication methods.

2019-12-19 Thread Tom Lane
Doc: add a short summary of available authentication methods. The "auth-methods" used to include descriptions of all our authentication methods. Commit 56811e573 promoted its child 's to 's, which has advantages but also created some issues: * The auth-methods page itself is essentially empty/us

pgsql: Update neglected comment.

2019-12-19 Thread Robert Haas
Update neglected comment. Commit d986d4e87f61c68f52c68ebc274960dc664b7b4e renamed a variable but neglected to update the corresponding comment. Amit Langote Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a9f304f5362f18b88fab04f342c99bd3d2c37944 Modified Fi

pgsql: Update neglected comment.

2019-12-19 Thread Robert Haas
Update neglected comment. Commit d986d4e87f61c68f52c68ebc274960dc664b7b4e renamed a variable but neglected to update the corresponding comment. Amit Langote Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7cdcc747a9fe588f9e9b3a5d3feb650340093fb2 Modified Files ---

pgsql: Fix minor problems with non-exclusive backup cleanup.

2019-12-19 Thread Robert Haas
Fix minor problems with non-exclusive backup cleanup. The previous coding imagined that it could call before_shmem_exit() when a non-exclusive backup began and then remove the previously-added handler by calling cancel_before_shmem_exit() when that backup ended. However, this only works provided t