Re: pgsql: Adjust test case added by commit 6136e94dc.

2019-12-20 Thread Andrew Dunstan
On Sat, Dec 21, 2019 at 7:15 AM Tom Lane wrote: > > Adjust test case added by commit 6136e94dc. > > Per project policy, transient roles created by regression test cases > should be named "regress_something", to reduce the risks of running > such cases against installed servers. And no such role s

pgsql: Adjust test case added by commit 6136e94dc.

2019-12-20 Thread Tom Lane
Adjust test case added by commit 6136e94dc. Per project policy, transient roles created by regression test cases should be named "regress_something", to reduce the risks of running such cases against installed servers. And no such role should ever be left behind after running a test. Discussion:

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

pgsql: libpq should expose GSS-related parameters even when not impleme

2019-12-20 Thread Tom Lane
libpq should expose GSS-related parameters even when not implemented. We realized years ago that it's better for libpq to accept all connection parameters syntactically, even if some are ignored or restricted due to lack of the feature in a particular build. However, that lesson from the SSL suppo

Re: pgsql: Superuser can permit passwordless connections on postgres_fdw

2019-12-20 Thread Michael Paquier
Hi Andrew, On Fri, Dec 20, 2019 at 05:55:10AM +, Andrew Dunstan wrote: > Superuser can permit passwordless connections on postgres_fdw > > Currently postgres_fdw doesn't permit a non-superuser to connect to a > foreign server without specifying a password, or to use an > authentication mechan

pgsql: Clean up inconsistent backslash use in paths

2019-12-20 Thread Peter Eisentraut
Clean up inconsistent backslash use in paths Most of the MSVC Perl code uses forward slashes for file paths. Make the few places that use backslashes the same. This also helps running that code on non-Windows. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77f416

pgsql: Generate pg_config.h from pg_config.h.in on Windows

2019-12-20 Thread Peter Eisentraut
Generate pg_config.h from pg_config.h.in on Windows Previously, the Windows MSVC build generated pg_config.h from a hard-coded pg_config.h.win32 with some ad hoc postprocessing. The pg_config.h.win32 file required manual maintenance and was as a result frequently out of date. Instead, have the M