pgsql: Fix typos in parallel query docs.

Fix typos in parallel query docs. Reported-by: Jon Jensen Author: Jon Jensen Reviewed-by: Amit Kapila and Robert Haas Backpatch-through: 10 Discussion: https://postgr.es/m/nycvar.YSQ.7.76.1912301807510.9899@ybpnyubfg Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix typos in parallel query docs.

Fix typos in parallel query docs. Reported-by: Jon Jensen Author: Jon Jensen Reviewed-by: Amit Kapila and Robert Haas Backpatch-through: 10 Discussion: https://postgr.es/m/nycvar.YSQ.7.76.1912301807510.9899@ybpnyubfg Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d

pgsql: Fix typos in parallel query docs.

Fix typos in parallel query docs. Reported-by: Jon Jensen Author: Jon Jensen Reviewed-by: Amit Kapila and Robert Haas Backpatch-through: 10 Discussion: https://postgr.es/m/nycvar.YSQ.7.76.1912301807510.9899@ybpnyubfg Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix typos in parallel query docs.

Fix typos in parallel query docs. Reported-by: Jon Jensen Author: Jon Jensen Reviewed-by: Amit Kapila and Robert Haas Backpatch-through: 10 Discussion: https://postgr.es/m/nycvar.YSQ.7.76.1912301807510.9899@ybpnyubfg Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Clear up btree_xlog_split() alignment comment.

Clear up btree_xlog_split() alignment comment. Adjust a comment that describes how alignment of the new left page high key works in btree_xlog_split(), the nbtree page split REDO routine. The wording used before commit 2c03216d831 is much clearer, so go back to that. Branch -- master Details

pgsql: Minor portability fixes for new TAP script.

Minor portability fixes for new TAP script. Satisfy perlcritic, mostly. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/90d7f6604b6ed2dcedee2884c3b01541600515cb Modified Files -- src/bin/psql/t/010_tab_completion.pl | 4 +++- 1 file chang

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

On Thu, Jan 2, 2020 at 7:50 PM Tom Lane wrote: > > Julien Rouhaud writes: > > On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: > >> Hmm, the buildfarm seems to think this screwed up something affecting > >> collations. Looking ... > > > Is ORDER BY 1 COLLATE "C" an option here? > > Nah, that woul

pgsql: Correct _bt_delitems_vacuum() lock comments.

Correct _bt_delitems_vacuum() lock comments. The expectation within _bt_delitems_vacuum() is that caller has a super-exclusive/cleanup buffer lock (not just a pin and a write lock). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/44e44bd258a71162444d41a1044c795f2c6d

pgsql: Fix cloning of row triggers to sub-partitions

Fix cloning of row triggers to sub-partitions When row triggers exist in partitioned partitions that are not either part of FKs or deferred unique constraints, they are not correctly cloned to their partitions. That's because they are marked "internal", and those are purposefully skipped when doi

pgsql: Fix cloning of row triggers to sub-partitions

Fix cloning of row triggers to sub-partitions When row triggers exist in partitioned partitions that are not either part of FKs or deferred unique constraints, they are not correctly cloned to their partitions. That's because they are marked "internal", and those are purposefully skipped when doi

pgsql: Fix cloning of row triggers to sub-partitions

Fix cloning of row triggers to sub-partitions When row triggers exist in partitioned partitions that are not either part of FKs or deferred unique constraints, they are not correctly cloned to their partitions. That's because they are marked "internal", and those are purposefully skipped when doi

pgsql: Add basic TAP tests for psql's tab-completion logic.

Add basic TAP tests for psql's tab-completion logic. Up to now, psql's tab-complete.c has had exactly no regression test coverage. This patch is an experimental attempt to add some. This needs Perl's IO::Pty module, which isn't installed everywhere, so the test script just skips all tests if tha

pgsql: Fix typmod exposed for scalar function in FROM, too.

Fix typmod exposed for scalar function in FROM, too. On further reflection about commit 4d02eb017, it occurs to me that expandRTE() had better agree with what addRangeTableEntryForFunction() is doing. So teach that about functions possibly having typmods, too. Branch -- master Details -

pgsql: Reorder two nbtree.h function prototypes.

Reorder two nbtree.h function prototypes. Make the function prototype order consistent with the definition order in nbtpage.c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a412f469880ede9f52336a7b383905129c2b03a0 Modified Files -- src/include/access/

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

Julien Rouhaud writes: > On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: >> Hmm, the buildfarm seems to think this screwed up something affecting >> collations. Looking ... > Is ORDER BY 1 COLLATE "C" an option here? Nah, that would just mask the bug not fix it. See 4d02eb017.

pgsql: Fix collation exposed for scalar function in FROM.

Fix collation exposed for scalar function in FROM. One code path in addRangeTableEntryForFunction() neglected to assign a collation to the tupdesc entry it constructs (which is a bit odd considering the other path did do so). This didn't matter before commit 5815696bc, because nothing would look

Re: pgsql: Update copyrights for 2020

On 2020-Jan-01, Bruce Momjian wrote: > Update copyrights for 2020 > > Backpatch-through: update all files in master, backpatch legal files through > 9.4 > src/test/ssl/ssl/client-der.key | Bin 1191 -> 1192 bytes > src/test/ssl/ssl/client-encrypted-der.key | Bin

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: > > Tom Lane writes: > > Make parser rely more heavily on the ParseNamespaceItem data structure. > > Hmm, the buildfarm seems to think this screwed up something affecting > collations. Looking ... My animal is using fr_FR collation by default, and

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

Tom Lane writes: > Make parser rely more heavily on the ParseNamespaceItem data structure. Hmm, the buildfarm seems to think this screwed up something affecting collations. Looking ... regards, tom lane

pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

Make parser rely more heavily on the ParseNamespaceItem data structure. When I added the ParseNamespaceItem data structure (in commit 5ebaaa494), it wasn't very tightly integrated into the parser's APIs. In the wake of adding p_rtindex to that struct (commit b541e9acc), there is a good reason to

pgsql: Fix comment in test

Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5cdf4629f7862ae081cb0357a014a3af2643bf1 Modified Files -- src/test/regress/expected/alter

pgsql: Fix comment in test

Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/198c7153dccb11950e3030dec564fdc6e59b4451 Modified Files -- src/test/regress/expected/alter_generi

pgsql: Fix comment in test

Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f565f530edcc4728ed004b7c75b876168df2daa0 Modified Files -- src/test/regress/expected/alter

pgsql: Fix comment in test

Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98b75c38c6ed2701c278316daac744222a1d56dd Modified Files -- src/test/regress/expected/alter