pgsql: Add xl_btree_delete optimization.

2020-01-03 Thread Peter Geoghegan
Add xl_btree_delete optimization. Commit 558a9165e08 taught _bt_delitems_delete() to produce its own XID horizon on the primary. Standbys no longer needed to generate their own latestRemovedXid, since they could just use the explicitly logged value from the primary instead. The deleted offset nu

pgsql: Further fixes for tab-completion TAP tests.

2020-01-03 Thread Tom Lane
Further fixes for tab-completion TAP tests. Escape non-printable characters in failure reports, by using Data::Dumper in Useqq mode. Also, bump $Test::Builder::Level so the diagnostic references the calling line, and use diag() instad of note(), so it shows even in non-verbose mode (per request f

pgsql: Add an ugly workaround for a bug in some recent libedit versions

2020-01-03 Thread Tom Lane
Add an ugly workaround for a bug in some recent libedit versions. Debian unstable is shipping a broken version of libedit: it de-escapes words before passing them to the application's tab completion function, preventing us from recognizing backslash commands. Fortunately, we have enough informati

Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

2020-01-03 Thread Tom Lane
Michael Paquier writes: > This has the disadvantage to have people never actually notice if the > tests are running or not because this does not generate a dependency > error. Skipping things if libreadline is not around is perfectly fine > IMO, but I think that we should harden things for IO::Pt

Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

2020-01-03 Thread Michael Paquier
On Thu, Jan 02, 2020 at 08:02:29PM +, Tom Lane wrote: > Add basic TAP tests for psql's tab-completion logic. > > Up to now, psql's tab-complete.c has had exactly no regression test > coverage. This patch is an experimental attempt to add some. > > This needs Perl's IO::Pty module, which isn'

pgsql: pgbench: Improve test description

2020-01-03 Thread Peter Eisentraut
pgbench: Improve test description Author: Fabien COELHO Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/04334fde69132f335d9d70cfefe419bd1276b232 Modified Files -- src/bin/pgbench/t/002_pgbench_no_server.pl | 2 +- 1 file changed, 1 insertion(+), 1 delet