Re: pgsql: Add reusable routine for making arrays unique.

2020-01-04 Thread Peter Geoghegan
On Wed, Nov 6, 2019 at 8:03 PM Thomas Munro wrote: > Add reusable routine for making arrays unique. I noticed that some of the copyright notices added by this commit look like this: + * Portions Copyright (c) 2019, PostgreSQL Global Development Group Shouldn't this simply read "Copyright (c) 20

pgsql: Avoid reading ~/.inputrc in tab-completion test, and revert othe

2020-01-04 Thread Tom Lane
Avoid reading ~/.inputrc in tab-completion test, and revert other changes. The true explanation for Peter Geoghegan's trouble report turns out to be that he has a ~/.inputrc that affects readline's behavior enough to break this test. Prevent readline from reading that file. Also, the best way to

pgsql: Don't try to force TERM to a fixed value in tab-completion test.

2020-01-04 Thread Tom Lane
Don't try to force TERM to a fixed value in tab-completion test. Right at the moment, this is making things worse not better in the buildfarm. I'm not happy with anything about the current state, but let's at least try to have a green buildfarm report while further investigation continues. Discu

pgsql: In tab-completion test, print out the value of TERM before chang

2020-01-04 Thread Tom Lane
In tab-completion test, print out the value of TERM before changing it. I'm curious to see what values are prevailing in the buildfarm. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/60ab7c80b4de2c3591

pgsql: Skip memcpy(x, x) in qunique().

2020-01-04 Thread Noah Misch
Skip memcpy(x, x) in qunique(). It has undefined behavior. Follow the precedent of commit 9a9473f3cce1a21c25d6cc7569710e832d2b180b. No back-patch, since the master branch alone has this function. Discussion: https://postgr.es/m/[email protected] Branch -- master Det

pgsql: Make tab-completion tests more robust.

2020-01-04 Thread Tom Lane
Make tab-completion tests more robust. Depending on as-yet-incompletely-explained factors, readline/libedit might choose to emit screen-control escape sequences as part of repainting the display. I'd tried to make the test patterns avoid matching parts of the output that are likely to contain suc

pgsql: Make better use of ParseState in ProcessUtility

2020-01-04 Thread Peter Eisentraut
Make better use of ParseState in ProcessUtility Pass ParseState into the functions called from standard_ProcessUtility() instead passing the query string and query environment separately. No functionality change, but it makes the notation consistent. We had already started moving things into tha