pgsql: Have logical replication subscriber fire column triggers

2020-01-05 Thread Peter Eisentraut
Have logical replication subscriber fire column triggers The logical replication apply worker did not fire per-column update triggers because the updatedCols bitmap in the RTE was not populated. This fixes that. Reviewed-by: Euler Taveira Discussion: https://www.postgresql.org/message-id/flat/2

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Andrew Dunstan
On Mon, Jan 6, 2020 at 3:50 PM Michael Paquier wrote: > On Mon, Jan 06, 2020 at 12:06:30AM -0500, Tom Lane wrote: > > As I recall, we'd already decided that nightjar needs to be EOL'd > > because that version of FreeBSD has nonatomic file rename [1]. > > Ah, indeed. I forgot this discussion, and

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Michael Paquier
On Mon, Jan 06, 2020 at 12:06:30AM -0500, Tom Lane wrote: > As I recall, we'd already decided that nightjar needs to be EOL'd > because that version of FreeBSD has nonatomic file rename [1]. Ah, indeed. I forgot this discussion, and that was not long ago. > You'll probably see failures from some

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Michael Paquier
On Mon, Jan 06, 2020 at 01:58:58PM +0900, Michael Paquier wrote: > So the buildfarm is not that bad, I have spotted one failure from > nightjar: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=nightjar&dt=2020-01-06%2003%3A54%3A10 > > /pgbuild/root/HEAD/pgsql.build/../pgsql/src/interface

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Tom Lane
Michael Paquier writes: > On Mon, Jan 06, 2020 at 03:53:08AM +, Michael Paquier wrote: >> Remove support for OpenSSL 0.9.8 and 1.0.0 > So the buildfarm is not that bad, I have spotted one failure from > nightjar: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=nightjar&dt=2020-01-06

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Michael Paquier
On Mon, Jan 06, 2020 at 03:53:08AM +, Michael Paquier wrote: > Remove support for OpenSSL 0.9.8 and 1.0.0 > > Support is out of scope from all the major vendors for these versions > (for example RHEL5 uses a version based on 0.9.8, and RHEL6 uses 1.0.1), > and it created some extra maintenance

pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-05 Thread Michael Paquier
Remove support for OpenSSL 0.9.8 and 1.0.0 Support is out of scope from all the major vendors for these versions (for example RHEL5 uses a version based on 0.9.8, and RHEL6 uses 1.0.1), and it created some extra maintenance work. Upstream has stopped support of 0.9.8 in December 2015 and of 1.0.0

Re: pgsql: Add reusable routine for making arrays unique.

2020-01-05 Thread Michael Paquier
On Sun, Jan 05, 2020 at 05:46:48PM -0800, Peter Geoghegan wrote: > On Sun, Jan 5, 2020 at 5:39 PM Alvaro Herrera > wrote: >> Looking at the stats, it's clear that it took a lot of code from other >> files, so it seems disingenuous to claim that it doesn't have even a >> single line that isn't cop

Re: pgsql: Add reusable routine for making arrays unique.

2020-01-05 Thread Peter Geoghegan
On Sun, Jan 5, 2020 at 5:39 PM Alvaro Herrera wrote: > Looking at the stats, it's clear that it took a lot of code from other > files, so it seems disingenuous to claim that it doesn't have even a > single line that isn't copyrighted by UCB regents. I took that claim at face value. Perhaps it wa

pgsql: Remove redundant incomplete split assertion.

2020-01-05 Thread Peter Geoghegan
Remove redundant incomplete split assertion. The fastpath insert optimization's incomplete split flag Assert() is redundant. We'll reach the more general Assert() within _bt_findinsertloc() in all cases. (Besides, Assert()'ing that the rightmost page doesn't have the flag set never made much sens

Re: pgsql: Add reusable routine for making arrays unique.

2020-01-05 Thread Alvaro Herrera
On 2020-Jan-04, Peter Geoghegan wrote: > On Wed, Nov 6, 2019 at 8:03 PM Thomas Munro wrote: > > Add reusable routine for making arrays unique. > > I noticed that some of the copyright notices added by this commit look > like this: > > + * Portions Copyright (c) 2019, PostgreSQL Global Developme

pgsql: Minor style improvements for tab-completion test.

2020-01-05 Thread Tom Lane
Minor style improvements for tab-completion test. Use qr// syntax for regex values. Include the regex that failed to match in diagnostic reports. Dagfinn Ilmari MannsÃ¥ker Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresq

pgsql: Docs: use more standard terminology "round-to-nearest-even" inst

2020-01-05 Thread Tatsuo Ishii
Docs: use more standard terminology "round-to-nearest-even" instead of "round-to-even". Per suggestion from Tom Lane. Discussion: https://postgr.es/m/flat/20191230.093451.1762483750956466101.t-ishii%40sraoss.co.jp Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: Docs: use more standard terminology "round-to-nearest-even" inst

2020-01-05 Thread Tatsuo Ishii
Docs: use more standard terminology "round-to-nearest-even" instead of "round-to-even". Per suggestion from Tom Lane. Discussion: https://postgr.es/m/flat/20191230.093451.1762483750956466101.t-ishii%40sraoss.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/95