Re: pgsql: tableam: New callback relation_fetch_toast_slice.

2020-01-07 Thread Michael Paquier
Hi Robert, On Tue, Jan 07, 2020 at 07:37:20PM +, Robert Haas wrote: > tableam: New callback relation_fetch_toast_slice. > > Instead of always calling heap_fetch_toast_slice during detoasting, > invoke a table AM callback which, when the toast table is a heap > table, will be heap_fetch_toast_

Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Michael Paquier
Hi Alvaro, On Tue, Jan 07, 2020 at 06:16:24PM -0300, Alvaro Herrera wrote: > So I misidentified things; it's not commit be87b70b6117 (pg11) that put > auxiliary processes in pg_stat_activity, but fc70a4b0df38 (pg10). So I > applied it back to pg10 also. (I did verify that walsenders appear with

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"

2020-01-07 Thread Michael Paquier
Revert "Forbid DROP SCHEMA on temporary namespaces" This reverts commit a052f6c, following complains from Robert Haas and Tom Lane. Backpatch down to 9.4, like the previous commit. Discussion: https://postgr.es/m/CA+TgmobL4npEX5=E5h=5jm_9mzun3mt39kq2sujfveamc9s...@mail.gmail.com Backpatch-throu

pgsql: Remove dependency to system calls for memory allocation in refin

2020-01-07 Thread Michael Paquier
Remove dependency to system calls for memory allocation in refint Failures in allocations could lead to crashes with NULL pointer dereferences . Memory context TopMemoryContext is used instead to keep alive the plans allocated in the session. A more specific context could be used here, but this

Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Alvaro Herrera
On 2020-Jan-07, Alvaro Herrera wrote: > pg_stat_activity: show NULL stmt start time for walsenders > > Returning a non-NULL time is pointless, sinc a walsender is not a > process that would be running normal transactions anyway, but the code > was unintentionally exposing the process start time i

pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Alvaro Herrera
pg_stat_activity: show NULL stmt start time for walsenders Returning a non-NULL time is pointless, sinc a walsender is not a process that would be running normal transactions anyway, but the code was unintentionally exposing the process start time intermittently, which was not only bogus but it al

pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Alvaro Herrera
pg_stat_activity: show NULL stmt start time for walsenders Returning a non-NULL time is pointless, sinc a walsender is not a process that would be running normal transactions anyway, but the code was unintentionally exposing the process start time intermittently, which was not only bogus but it al

pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Alvaro Herrera
pg_stat_activity: show NULL stmt start time for walsenders Returning a non-NULL time is pointless, sinc a walsender is not a process that would be running normal transactions anyway, but the code was unintentionally exposing the process start time intermittently, which was not only bogus but it al

pgsql: pg_stat_activity: show NULL stmt start time for walsenders

2020-01-07 Thread Alvaro Herrera
pg_stat_activity: show NULL stmt start time for walsenders Returning a non-NULL time is pointless, sinc a walsender is not a process that would be running normal transactions anyway, but the code was unintentionally exposing the process start time intermittently, which was not only bogus but it al

pgsql: tableam: New callback relation_fetch_toast_slice.

2020-01-07 Thread Robert Haas
tableam: New callback relation_fetch_toast_slice. Instead of always calling heap_fetch_toast_slice during detoasting, invoke a table AM callback which, when the toast table is a heap table, will be heap_fetch_toast_slice. This makes it possible for a table AM other than heap to be used as a TOAST

pgsql: tableam: Allow choice of toast AM.

2020-01-07 Thread Robert Haas
tableam: Allow choice of toast AM. Previously, the toast table had to be implemented by the same AM that was used for the main table, which was bad, because the detoasting code won't work with anything but heap. This commit doesn't fix the latter problem, although there's another patch coming whic

pgsql: Increase the maximum value of track_activity_query_size.

2020-01-07 Thread Robert Haas
Increase the maximum value of track_activity_query_size. This one-line change provoked a lot of discussion, but ultimately the consensus seems to be that allowing a larger value might be useful to somebody, and probably won't hurt anyone who chooses not to take advantage of the higher maximum limi

Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0

2020-01-07 Thread Michael Paquier
On Mon, Jan 06, 2020 at 05:18:02PM +1030, Andrew Dunstan wrote: > I was going to upgrade it when I could migrate the OS of the host machine > to CentOS 8. However, last time I looked some things about Centos 8 (e.g. > EPEL) were not mature enough. In any case, to do that requires my physical > pre