pgsql: Fix dispsize for libpq connection parameters channel_binding and

2020-01-28 Thread Michael Paquier
Fix dispsize for libpq connection parameters channel_binding and gssencmode channel_binding's longest allowed value is not "7", it is actually "8". gssencmode also got that wrong. A similar mistake has been fixed as of f4051e3. Backpatch down to v12, where gssencmode has been introduced. Review

pgsql: Fix dispsize for libpq connection parameters channel_binding and

2020-01-28 Thread Michael Paquier
Fix dispsize for libpq connection parameters channel_binding and gssencmode channel_binding's longest allowed value is not "7", it is actually "8". gssencmode also got that wrong. A similar mistake has been fixed as of f4051e3. Backpatch down to v12, where gssencmode has been introduced. Review

pgsql: Add --parallel option to vacuumdb command.

2020-01-28 Thread Amit Kapila
Add --parallel option to vacuumdb command. Commit 40d964ec99 allowed vacuum command to leverage multiple CPUs by invoking parallel workers to process indexes. This commit provides a '--parallel' option to specify the parallel degree used by vacuum command. Author: Masahiko Sawada, with few modif

Re: pgsql: Add a non-strict version of jsonb_set

2020-01-28 Thread Michael Paquier
On Tue, Jan 28, 2020 at 10:37:00AM -0500, Robert Haas wrote: > On Tue, Jan 28, 2020 at 10:36 AM Robert Haas wrote: >> Another thing that would be nice is to warn about commits that don't >> include a "Description:" line. I have been trying to be religious >> about that, but I seem to periodically

pgsql: Fix dangling pointer in EvalPlanQual machinery.

2020-01-28 Thread Tom Lane
Fix dangling pointer in EvalPlanQual machinery. EvalPlanQualStart() supposed that it could re-use the relsubs_rowmark and relsubs_done arrays from a prior instantiation. But since they are allocated in the es_query_cxt of the recheckestate, that's just wrong; EvalPlanQualEnd() will blow away that

pgsql: Fix dangling pointer in EvalPlanQual machinery.

2020-01-28 Thread Tom Lane
Fix dangling pointer in EvalPlanQual machinery. EvalPlanQualStart() supposed that it could re-use the relsubs_rowmark and relsubs_done arrays from a prior instantiation. But since they are allocated in the es_query_cxt of the recheckestate, that's just wrong; EvalPlanQualEnd() will blow away that

Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.

2020-01-28 Thread Tom Lane
Thomas Munro writes: > On Wed, Jan 29, 2020 at 4:05 AM Tom Lane wrote: >> There is absolutely no question that the original coding is illegal >> per spec, and it isn't even a particularly useful shorthand; so why >> can't we get even a warning about it? > $ cc -c -Wpedantic test.c > test.c:2:12:

Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.

2020-01-28 Thread Thomas Munro
On Wed, Jan 29, 2020 at 4:05 AM Tom Lane wrote: > Thomas Munro writes: > > On Tue, Jan 28, 2020 at 6:59 PM Tom Lane wrote: > >> anole's not terribly pleased with this: > >> "heapam.c", line 9137: error #2118: a void function may not return a value > >> return CheckForSerializableConflictOut(rela

Re: pgsql: Add a non-strict version of jsonb_set

2020-01-28 Thread Robert Haas
On Tue, Jan 28, 2020 at 10:36 AM Robert Haas wrote: > Another thing that would be nice is to warn about commits that don't > include a "Description:" line. I have been trying to be religious > about that, but I seem to periodically apostatize. And of course I meant "Discussion". :-( -- Robert H

Re: pgsql: Add a non-strict version of jsonb_set

2020-01-28 Thread Robert Haas
On Sun, Jan 19, 2020 at 7:19 PM Tom Lane wrote: > Ah, that makes sense. Although Mark's idea of including a library > of possible hooks somewhere under src/tools/ seems even better. +1. And directions for setting them up (or, as I think he was proposing, a script, but directions might be better)

Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.

2020-01-28 Thread Tom Lane
Thomas Munro writes: > On Tue, Jan 28, 2020 at 6:59 PM Tom Lane wrote: >> anole's not terribly pleased with this: >> "heapam.c", line 9137: error #2118: a void function may not return a value >> return CheckForSerializableConflictOut(relation, xid, snapshot); > Thanks. I pushed a fix. > Wow, HP

pgsql: Fix randAccess setting in ReadRecord()

2020-01-28 Thread Heikki Linnakangas
Fix randAccess setting in ReadRecord() Commit 38a957316d got this backwards. Author: Kyotaro Horiguchi Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/300