Re: pgsql: Record parents of triggers

2020-02-27 Thread Michael Paquier
On Thu, Feb 27, 2020 at 05:23:44PM -0300, Alvaro Herrera wrote: > Augh. Yeah, will push one now. devario is complaining with a cache lookup error: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=devario&dt=2020-02-27%2014%3A18%3A34 --- /tmp/buildroot/HEAD/pgsql.build/src/test/regress/exp

Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Tom Lane
Jeff Davis writes: > On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote: >> Surely this patch is a few bricks shy of a load. Don't you need >> copyfuncs/readfuncs/outfuncs support, for starters? > Sorry, I will fix it. > I was looking at whether changes to copyfuncs (etc.) should also cause > a

Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Jeff Davis
On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote: > Jeff Davis writes: > > Save calculated transitionSpace in Agg node. > > Surely this patch is a few bricks shy of a load. Don't you need > copyfuncs/readfuncs/outfuncs support, for starters? Sorry, I will fix it. I was looking at whether chan

pgsql: Catversion bump for b9b408c48724

2020-02-27 Thread Alvaro Herrera
Catversion bump for b9b408c48724 Per Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/afb5465e0cfce7637066eaaaeecab30b0f23fbe3 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Record parents of triggers

2020-02-27 Thread Alvaro Herrera
On 2020-Feb-27, Tom Lane wrote: > Alvaro Herrera writes: > > Modified Files > > -- > > doc/src/sgml/catalogs.sgml | 11 ++ > > src/backend/commands/tablecmds.c | 59 > > +++--- > > src/backend/commands/trigger.c | 1 + >

Re: pgsql: Record parents of triggers

2020-02-27 Thread Tom Lane
Alvaro Herrera writes: > Modified Files > -- > doc/src/sgml/catalogs.sgml | 11 ++ > src/backend/commands/tablecmds.c | 59 +++--- > src/backend/commands/trigger.c | 1 + > src/include/catalog/pg_trigger.h | 1 +

Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Tom Lane
Jeff Davis writes: > Save calculated transitionSpace in Agg node. Surely this patch is a few bricks shy of a load. Don't you need copyfuncs/readfuncs/outfuncs support, for starters? regards, tom lane

pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Jeff Davis
Save calculated transitionSpace in Agg node. This will be useful in the upcoming Hash Aggregation work to improve estimates for hash table sizing. Discussion: https://postgr.es/m/37091115219dd522fd9ed67333ee8ed1b7e09443.camel%40j-davis.com Branch -- master Details --- https://git.postg

pgsql: Doc: Fix deduplicate_items index term.

2020-02-27 Thread Peter Geoghegan
Doc: Fix deduplicate_items index term. Reported-By: Fujii Masao Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e537aed61db767745b614600be15cd19bb581330 Modified Files ---

Re: pgsql: Add deduplication to nbtree.

2020-02-27 Thread Peter Geoghegan
On Thu, Feb 27, 2020 at 9:25 AM Laurenz Albe wrote: > This is great! Thanks! Thanks! > Are no changes to the "pageinspect" contrib required? There are. Those will be pushed either today or tomorrow. -- Peter Geoghegan

Re: pgsql: Add deduplication to nbtree.

2020-02-27 Thread Laurenz Albe
On Wed, 2020-02-26 at 21:06 +, Peter Geoghegan wrote: > Add deduplication to nbtree. This is great! Thanks! Are no changes to the "pageinspect" contrib required? Yours, Laurenz Albe

pgsql: Record parents of triggers

2020-02-27 Thread Alvaro Herrera
Record parents of triggers This let us get rid of a recently introduced ugly hack (commit 1fa846f1c9af). Author: Álvaro Herrera Reviewed-by: Amit Langote, Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.o

Re: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

2020-02-27 Thread Alvaro Herrera
On 2020-Feb-27, Michael Paquier wrote: > Now looking at the code of OpenBSD there could be an > alternative: using a string longer than 256 characters if I read > lib/libc/locale/setlocale.c correctly, but I'd rather not rely on > that. That seems awfully fragile. Belated +1 for not relying on t

Re: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

2020-02-27 Thread Michael Paquier
On Thu, Feb 27, 2020 at 02:11:12PM +0900, Michael Paquier wrote: > The best thing I can think of is just to remove the test case for > --lc-ctype. So, thinking about nothing better, I have just removed this test. -- Michael signature.asc Description: PGP signature

pgsql: Remove TAP test for createdb --lc-ctype

2020-02-27 Thread Michael Paquier
Remove TAP test for createdb --lc-ctype OpenBSD falls back to "C" when using an incorrect input with setlocale() and LC_CTYPE, causing this test, introduced by 008cf04, to fail. This removes the culprit test to avoid the portability issue. Per report from Robert Haas, via buildfarm member curcul

pgsql: Remove TAP test for createdb --lc-ctype

2020-02-27 Thread Michael Paquier
Remove TAP test for createdb --lc-ctype OpenBSD falls back to "C" when using an incorrect input with setlocale() and LC_CTYPE, causing this test, introduced by 008cf04, to fail. This removes the culprit test to avoid the portability issue. Per report from Robert Haas, via buildfarm member curcul

pgsql: Remove TAP test for createdb --lc-ctype

2020-02-27 Thread Michael Paquier
Remove TAP test for createdb --lc-ctype OpenBSD falls back to "C" when using an incorrect input with setlocale() and LC_CTYPE, causing this test, introduced by 008cf04, to fail. This removes the culprit test to avoid the portability issue. Per report from Robert Haas, via buildfarm member curcul