pgsql: Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro.

2020-03-13 Thread Tom Lane
Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro. This should of course be just "PG_ARGISNULL()". Also reorder a couple of paras to make the discussion of PG_ARGISNULL less disjointed. Back-patch to v10 where the error was introduced. Laurenz Albe and Tom Lane, per an anonymous docs comm

pgsql: Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro.

2020-03-13 Thread Tom Lane
Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro. This should of course be just "PG_ARGISNULL()". Also reorder a couple of paras to make the discussion of PG_ARGISNULL less disjointed. Back-patch to v10 where the error was introduced. Laurenz Albe and Tom Lane, per an anonymous docs comm

pgsql: Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro.

2020-03-13 Thread Tom Lane
Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro. This should of course be just "PG_ARGISNULL()". Also reorder a couple of paras to make the discussion of PG_ARGISNULL less disjointed. Back-patch to v10 where the error was introduced. Laurenz Albe and Tom Lane, per an anonymous docs comm

pgsql: Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro.

2020-03-13 Thread Tom Lane
Doc: fix mistaken reference to "PG_ARGNULL_xxx()" macro. This should of course be just "PG_ARGISNULL()". Also reorder a couple of paras to make the discussion of PG_ARGISNULL less disjointed. Back-patch to v10 where the error was introduced. Laurenz Albe and Tom Lane, per an anonymous docs comm

pgsql: doc: Remove unused title ids

2020-03-13 Thread Peter Eisentraut
doc: Remove unused title ids FOP issues warnings about them. These aren't even used, so just remove them. For the ones that are actually used, we'll come up with a different solution. Discussion: https://www.postgresql.org/message-id/flat/e29b580e-79ab-a371-5ea4-6946e4d3af0b%402ndQuadrant.com

pgsql: Unify several ways to tracking backend type

2020-03-13 Thread Peter Eisentraut
Unify several ways to tracking backend type Add a new global variable MyBackendType that uses the same BackendType enum that was previously only used by the stats collector. That way several duplicate ways of checking what type a particular process is can be simplified. Since it's no longer just

pgsql: Remove am_syslogger global variable

2020-03-13 Thread Peter Eisentraut
Remove am_syslogger global variable Use the new MyBackendType instead. More similar changes for other "am something" variables are possible. This one was just particularly simple. Reviewed-by: Julien Rouhaud Reviewed-by: Kuntal Ghosh Reviewed-by: Alvaro Herrera Discussion: https://www.postg

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we

pgsql: Preserve replica identity index across ALTER TABLE rewrite

2020-03-13 Thread Peter Eisentraut
Preserve replica identity index across ALTER TABLE rewrite If an index was explicitly set as replica identity index, this setting was lost when a table was rewritten by ALTER TABLE. Because this setting is part of pg_index but actually controlled by ALTER TABLE (not part of CREATE INDEX, say), we