Re: pgsql: Disk-based Hash Aggregation.

2020-03-22 Thread Tom Lane
Jeff Davis writes: > Disk-based Hash Aggregation. I noticed that the regression tests seemed suddenly slower than they have been. A bit of poking around reveals that this patch made groupingsets.sql take approximately 8X longer than it used to, and more than twice as long as any other core regre

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Revert "Refactor compile-time assertion checks in c.h"

2020-03-22 Thread Michael Paquier
Revert "Refactor compile-time assertion checks in c.h" This reverts commit b7f64c6, which broke the fallback implementation for C++. We have discussed a couple of alternatives to reduce the number of implementations for those asserts, but nothing allowing to reduce the number of implementations d

pgsql: Doc: Fix type of some storage parameters in CREATE TABLE page

2020-03-22 Thread Michael Paquier
Doc: Fix type of some storage parameters in CREATE TABLE page autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor have been documented as "float4", but "floating type" is used in this case for GUCs and relation options in the documentation. Author: Atsushi Torikoshi Discussion: ht

pgsql: Add object names to partition integrity violations.

2020-03-22 Thread Amit Kapila
Add object names to partition integrity violations. All errors of SQLSTATE class 23 should include the name of an object associated with the error in separate fields of the error report message. We do this so that applications need not try to extract them from the possibly-localized human-readable

pgsql: Add bound checks for ssl_min_protocol_version and ssl_max_protoc

2020-03-22 Thread Michael Paquier
Add bound checks for ssl_min_protocol_version and ssl_max_protocol_version Mixing incorrect bounds in the SSL context leads to confusing error messages generated by OpenSSL which are hard to act on. New range checks are added when both min/max parameters are loaded in the context of a SSL reload

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p

pgsql: Revert "Skip WAL for new relfilenodes, under wal_level=minimal."

2020-03-22 Thread Noah Misch
Revert "Skip WAL for new relfilenodes, under wal_level=minimal." This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per numerous buildfarm members, it was incompatible with parallel query, and a test case assumed LP64. Back-patch to 9.5 (all supported versions). Discussion: https://p