Re: pgsql: Include information on buffer usage during planning phase, in EX

2020-04-02 Thread Fujii Masao
On 2020/04/03 12:30, Tom Lane wrote: Fujii Masao writes: On 2020/04/03 11:58, Michael Paquier wrote: prion did not like that: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-04-03%2002%3A33%3A13 dory failed as well. The problem is that in text mode, a Buffers line w

Re: pgsql: Include information on buffer usage during planning phase, in EX

2020-04-02 Thread Tom Lane
Fujii Masao writes: > On 2020/04/03 11:58, Michael Paquier wrote: >> prion did not like that: >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-04-03%2002%3A33%3A13 dory failed as well. The problem is that in text mode, a Buffers line won't appear at all if there were zero

Re: pgsql: Include information on buffer usage during planning phase, in EX

2020-04-02 Thread Fujii Masao
On 2020/04/03 11:58, Michael Paquier wrote: Hi Fujii-san, On Fri, Apr 03, 2020 at 02:28:27AM +, Fujii Masao wrote: Include information on buffer usage during planning phase, in EXPLAIN output. When BUFFERS option is enabled, EXPLAIN command includes the information on buffer usage durin

pgsql: Revert "Include information on buffer usage during planning phas

2020-04-02 Thread Fujii Masao
Revert "Include information on buffer usage during planning phase, in EXPLAIN output." This reverts commit ed7a5095716ee498ecc406e1b8d5ab92c7662d10. Per buildfarm member prion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/19db23bcbda99e93321cb0636677ec9c6e121a2

pgsql: Add wait events for recovery conflicts.

2020-04-02 Thread Fujii Masao
Add wait events for recovery conflicts. This commit introduces new wait events RecoveryConflictSnapshot and RecoveryConflictTablespace. The former is reported while waiting for recovery conflict resolution on a vacuum cleanup. The latter is reported while waiting for recovery conflict resolution o

Re: pgsql: Include information on buffer usage during planning phase, in EX

2020-04-02 Thread Michael Paquier
Hi Fujii-san, On Fri, Apr 03, 2020 at 02:28:27AM +, Fujii Masao wrote: > Include information on buffer usage during planning phase, in EXPLAIN output. > > When BUFFERS option is enabled, EXPLAIN command includes the information > on buffer usage during each plan node, in its output. In additi

pgsql: Add support for \aset in pgbench

2020-04-02 Thread Michael Paquier
Add support for \aset in pgbench This option is similar to \gset, except that it is able to store all results from combined SQL queries into separate variables. If a query returns multiple rows, the last result is stored and if a query returns no rows, nothing is stored. While on it, add a TAP t

pgsql: Include information on buffer usage during planning phase, in EX

2020-04-02 Thread Fujii Masao
Include information on buffer usage during planning phase, in EXPLAIN output. When BUFFERS option is enabled, EXPLAIN command includes the information on buffer usage during each plan node, in its output. In addition to that, this commit makes EXPLAIN command include also the information on buffer

Re: pgsql: pg_waldump: Add a --quiet option.

2020-04-02 Thread Fujii Masao
On 2020/04/03 10:11, Robert Haas wrote: pg_waldump: Add a --quiet option. The primary motivation for this change is that it will be used by the upcoming patch to add backup manifests, but it also seems to have some potential more general use. I'm not sure what the actual purpose of this fea

pgsql: pg_waldump: Add a --quiet option.

2020-04-02 Thread Robert Haas
pg_waldump: Add a --quiet option. The primary motivation for this change is that it will be used by the upcoming patch to add backup manifests, but it also seems to have some potential more general use. Andres Freund and Robert Haas Discussion: http://postgr.es/m/20200330020814.nspra4mvby42y...@

pgsql: Improve stability fix for partition_aggregate test.

2020-04-02 Thread Tom Lane
Improve stability fix for partition_aggregate test. Instead of disabling autovacuum on these test tables, adjust the partition boundaries so that the child partitions are not all the same size. That should cause the planner to use a predictable ordering of the per-partition scan nodes even in cas

Re: pgsql: doc: remove mention of bitwise operators as solely type-limited

2020-04-02 Thread Bruce Momjian
On Thu, Apr 2, 2020 at 07:23:06AM +0200, Peter Eisentraut wrote: > On 2020-04-01 00:44, Bruce Momjian wrote: > > doc: remove mention of bitwise operators as solely type-limited > > > > There are other operators that have limited number data type support, so > > just remove the sentence. > >

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

Re: pgsql: doc: add namespace column to pg_buffercache example query

2020-04-02 Thread Bruce Momjian
On Thu, Apr 2, 2020 at 07:35:50AM +0200, Peter Eisentraut wrote: > On 2020-03-31 23:16, Bruce Momjian wrote: > > doc: add namespace column to pg_buffercache example query > > > > Without the namespace, the table name could be ambiguous. > > > > Reported-by: [email protected] > > > > Disc

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

pgsql: doc: remove unnecessary INNER keyword

2020-04-02 Thread Bruce Momjian
doc: remove unnecessary INNER keyword A join that was added in commit 9b2009c4cf that did not use the INNER keyword but the existing query used it. It was cleaner to remove the existing INNER keyword. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/a1ffbfda-59d2-5732-e5fb-3df8582

Re: pgsql: doc: adjust UPDATE/DELETE's FROM/USING to match SELECT's FROM

2020-04-02 Thread Bruce Momjian
On Thu, Apr 2, 2020 at 07:32:49AM +0200, Peter Eisentraut wrote: > On 2020-03-31 22:31, Bruce Momjian wrote: > > doc: adjust UPDATE/DELETE's FROM/USING to match SELECT's FROM > > > > Previously the syntax and wording were unclear. > > @@ -23,7 +23,7 @@ PostgreSQL documentation > > [ WITH [ RE

Re: pgsql: doc: clarify hierarchy of objects: global, db, schema, etc.

2020-04-02 Thread Bruce Momjian
On Thu, Apr 2, 2020 at 07:27:53AM +0200, Peter Eisentraut wrote: > On 2020-04-01 00:10, Bruce Momjian wrote: > > doc: clarify hierarchy of objects: global, db, schema, etc. > > > > The previous wording was confusing because it wasn't in decreasing order > > and had to backtrack. Also clarify r

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c713dc2f7be314ee541f0abd170b

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8a043d8673289c2a0c625

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bd2cfe40f841d355c42db

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa9749ed95cadb8478e98

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf09e83dbc8ba8196b101

pgsql: doc: remove comma, related to commit 92d31085e9

2020-04-02 Thread Bruce Momjian
doc: remove comma, related to commit 92d31085e9 Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a38f099aff2772ecdc6b5

pgsql: Improve user control over truncation of logged bind-parameter va

2020-04-02 Thread Tom Lane
Improve user control over truncation of logged bind-parameter values. This patch replaces the boolean GUC log_parameters_on_error introduced by commit ba79cb5dc with an integer log_parameter_max_length_on_error, adding the ability to specify how many bytes to trim each logged parameter value to.

pgsql: Fix typo in SLRU stats documentation

2020-04-02 Thread Tomas Vondra
Fix typo in SLRU stats documentation Author: Noriyoshi Shinoda Discussion: https://www.postgresql.org/message-id/flat/20200119143707.gyinppnigokesjok@development Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2c220ca46f3f6de0611367312bec0daef99b29eb Modified File

pgsql: Attempt to stabilize partitionwise_aggregate test

2020-04-02 Thread David Rowley
Attempt to stabilize partitionwise_aggregate test In b07642dbc, we added code to trigger autovacuums based on the number of INSERTs into a table. This seems to have cause some destabilization of the regression tests. Likely this is due to an autovacuum triggering mid-test and (per theory from Tom

Re: pgsql: Fix whitespace

2020-04-02 Thread Fujii Masao
On 2020/04/02 16:07, Peter Eisentraut wrote: Fix whitespace Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

pgsql: Add SQL functions for Unicode normalization

2020-04-02 Thread Peter Eisentraut
Add SQL functions for Unicode normalization This adds SQL expressions NORMALIZE() and IS NORMALIZED to convert and check Unicode normal forms, per SQL standard. To support fast IS NORMALIZED tests, we pull in a new data file DerivedNormalizationProps.txt from Unicode and build a lookup table from

pgsql: Fix whitespace

2020-04-02 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/070c3d3937e75e04d36405287353b7eca516555d Modified Files -- contrib/pg_stat_statements/pg_stat_statements--1.7--1.8.sql | 2 -- 1 file changed, 2 deletions(-)

Re: pgsql: doc: remove mention of bitwise operators as solely type-limited

2020-04-02 Thread Peter Eisentraut
On 2020-04-01 00:44, Bruce Momjian wrote: doc: remove mention of bitwise operators as solely type-limited There are other operators that have limited number data type support, so just remove the sentence. -The bitwise operators work only on integral data types, whereas -the other