pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

pgsql: Fix error case for CREATE ROLE ... IN ROLE.

2020-04-24 Thread Andrew Gierth
Fix error case for CREATE ROLE ... IN ROLE. CreateRole() was passing a Value node, not a RoleSpec node, for the newly-created role name when adding the role as a member of existing roles for the IN ROLE syntax. This mistake went unnoticed because the node in question is used only for error messag

Re: pgsql: Fix handling of WAL segments ready to be archived during crash r

2020-04-24 Thread Michael Paquier
On Fri, Apr 24, 2020 at 05:30:21PM +0900, Kyotaro Horiguchi wrote: > I think we can reimplement them by waiting > pg_stat_archiver.last_failed_wal at least for archive_mode=always > case. I'm not sure about the case where archive_mode=on, though. Yeah, the second case is more tricky, and there is

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/40d4bc5acd0aeaf4fbbd4716a22f998b2580f42b

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3cdb45c5498dcf76db374e54b31d8a240c21fa9d

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c5f9161682697418156b6391038318d130fe6e4 Modifi

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

2020-04-24 Thread Tom Lane
Improve placement of "display name" comment in win32_tzmap[] entries. Sticking this comment at the end of the last line was a bad idea: it's not particularly readable, and it tempts pgindent to mess with line breaks within the comment, which in turn reveals that win32tzlist.pl's clean_displayname(

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1e07e3fc0076d96954f32223efc93b6468e441a4

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b31f9fd63341441717ddd364cfef9a89afb75677

pgsql: Update Windows timezone name list to include currently-known zon

2020-04-24 Thread Tom Lane
Update Windows timezone name list to include currently-known zones. Thanks to Juan José Santamaría Flecha. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f65f3a5d8e724c8ea425bf7a12e447b23e532779

pgsql: Doc: update section 9.13 for new function table layout.

2020-04-24 Thread Tom Lane
Doc: update section 9.13 for new function table layout. This includes the usual amount of editorial cleanup, such as correcting wrong or less-helpful-than-they-could-be examples. I moved the two tsvector-updating triggers into "9.28 Trigger Functions", which seems like a better home for them. (I

pgsql: git_changelog: use modern format for rel branch names in example

2020-04-24 Thread Bruce Momjian
git_changelog: use modern format for rel branch names in example e.g., REL_12_STABLE Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/395a9a124877d3c41328fcfebcf0c68df86d9bfd Modified Files -- src/tools/git_changelog | 2 +- 1 file changed, 1 insertion(+)

pgsql: Try to avoid compiler warnings in optimized builds.

2020-04-24 Thread Robert Haas
Try to avoid compiler warnings in optimized builds. Per report from Andres Freund, who also says that this fix works for him. Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05021a2c0c

pgsql: Repair performance regression in information_schema.triggers vie

2020-04-24 Thread Tom Lane
Repair performance regression in information_schema.triggers view. Commit 32ff26911 introduced use of rank() into the triggers view to calculate the spec-mandated action_order column. As written, this prevents query constraints on the table-name column from being pushed below the window aggregate

pgsql: Repair performance regression in information_schema.triggers vie

2020-04-24 Thread Tom Lane
Repair performance regression in information_schema.triggers view. Commit 32ff26911 introduced use of rank() into the triggers view to calculate the spec-mandated action_order column. As written, this prevents query constraints on the table-name column from being pushed below the window aggregate

pgsql: Repair performance regression in information_schema.triggers vie

2020-04-24 Thread Tom Lane
Repair performance regression in information_schema.triggers view. Commit 32ff26911 introduced use of rank() into the triggers view to calculate the spec-mandated action_order column. As written, this prevents query constraints on the table-name column from being pushed below the window aggregate

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

pgsql: Update time zone data files to tzdata release 2020a.

2020-04-24 Thread Tom Lane
Update time zone data files to tzdata release 2020a. DST law changes in Morocco and the Canadian Yukon. Historical corrections for Shanghai. The America/Godthab zone is renamed to America/Nuuk to reflect current English usage; however, the old name remains available as a compatibility link. Bran

Re: pgsql: Fix handling of WAL segments ready to be archived during crash r

2020-04-24 Thread Kyotaro Horiguchi
At Fri, 24 Apr 2020 10:14:37 +0900, Michael Paquier wrote in > On Fri, Apr 24, 2020 at 09:59:29AM +0900, Michael Paquier wrote: > > And this visibly comes down to the fact that we don't take care enough > > of the timing between the restartpoints done, the startup process > > doing its recycling

Re: pgsql: Skip WAL for new relfilenodes, under wal_level=minimal.

2020-04-24 Thread Kyotaro Horiguchi
At Fri, 24 Apr 2020 16:29:41 +0900, Michael Paquier wrote in > Hi Noah, > > On Sat, Apr 04, 2020 at 08:40:43PM +, Noah Misch wrote: > > Skip WAL for new relfilenodes, under wal_level=minimal. > > > > Until now, only selected bulk operations (e.g. COPY) did this. If a > > given relfilenode

pgsql: Update Unicode data to Unicode 13.0.0 and CLDR 37

2020-04-24 Thread Peter Eisentraut
Update Unicode data to Unicode 13.0.0 and CLDR 37 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3a8961577677dd4e910ed239047ad6c02cb2591b Modified Files -- contrib/unaccent/unaccent.rules | 99 src/Makefile.global.in

Re: pgsql: Skip WAL for new relfilenodes, under wal_level=minimal.

2020-04-24 Thread Michael Paquier
Hi Noah, On Sat, Apr 04, 2020 at 08:40:43PM +, Noah Misch wrote: > Skip WAL for new relfilenodes, under wal_level=minimal. > > Until now, only selected bulk operations (e.g. COPY) did this. If a > given relfilenode received both a WAL-skipping COPY and a WAL-logged > operation (e.g. INSERT),