pgsql: Improve comments for [Heap]CheckForSerializableConflictOut().

2020-06-11 Thread Thomas Munro
Improve comments for [Heap]CheckForSerializableConflictOut(). Rewrite the documentation of these functions, in light of recent bug fix commit 5940ffb2. Back-patch to 13 where the check-for-conflict-out code was split up into AM-specific and generic parts, and new documentation was added that now

pgsql: Improve comments for [Heap]CheckForSerializableConflictOut().

2020-06-11 Thread Thomas Munro
Improve comments for [Heap]CheckForSerializableConflictOut(). Rewrite the documentation of these functions, in light of recent bug fix commit 5940ffb2. Back-patch to 13 where the check-for-conflict-out code was split up into AM-specific and generic parts, and new documentation was added that now

pgsql: doc: document problems with using xreflabel in XML docs

2020-06-11 Thread Bruce Momjian
doc: document problems with using xreflabel in XML docs Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/59fa7eb60364b8e71

pgsql: doc: remove xreflabels used in PG 13 relnotes

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels used in PG 13 relnotes xreflabels were removed in a previous commit Discussion: https://postgr.es/m/[email protected] Backpatch-through: 13 only Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/db68

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

pgsql: doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5

2020-06-11 Thread Bruce Momjian
doc: remove xreflabels from commits 75fcdd2ae2 and 85af628da5 xreflabels prevent references to the chapter numbers of sections id's. It should only be used in specific cases. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch ---

Re: pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
On Thu, 2020-06-11 at 13:41 -0700, Peter Geoghegan wrote: > On Thu, Jun 11, 2020 at 1:05 PM Jeff Davis > wrote: > > Rework HashAgg GUCs. > > This commit broke the doc build: Fixed, thank you. It broke the REL_13_STABLE branch, not master, so I fixed it only in 13. Regards, Jeff Davis

pgsql: Fix doc build, broken by 13e0fa7a.

2020-06-11 Thread Jeff Davis
Fix doc build, broken by 13e0fa7a. Reported-by: Peter Geoghegan Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6fbfa4eb244eab47d67fba4258c4af29f119 Modified Files -- doc/src/sgml/release-13.sgml | 8 +--- 1 file changed, 1 insertion(+), 7

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

pgsql: Fix mishandling of NaN counts in numeric_[avg_]combine.

2020-06-11 Thread Tom Lane
Fix mishandling of NaN counts in numeric_[avg_]combine. When merging two NumericAggStates, the code missed adding the new state's NaNcount unless its N was also nonzero; since those counts are independent, this is wrong. This would only have visible effect if some partial aggregate scans found on

Re: pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Peter Geoghegan
On Thu, Jun 11, 2020 at 1:05 PM Jeff Davis wrote: > Rework HashAgg GUCs. This commit broke the doc build: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2020-06-11%2020%3A17%3A29 Thanks -- Peter Geoghegan

pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
Rework HashAgg GUCs. Eliminate enable_groupingsets_hash_disk, which was primarily useful for testing grouping sets that use HashAgg and spill. Instead, hack the table stats to convince the planner to choose hashed aggregation for grouping sets that will spill to disk. Suggested by Melanie Plageman

pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
Rework HashAgg GUCs. Eliminate enable_groupingsets_hash_disk, which was primarily useful for testing grouping sets that use HashAgg and spill. Instead, hack the table stats to convince the planner to choose hashed aggregation for grouping sets that will spill to disk. Suggested by Melanie Plageman

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: Avoid update conflict out serialization anomalies.

2020-06-11 Thread Peter Geoghegan
Avoid update conflict out serialization anomalies. SSI's HeapCheckForSerializableConflictOut() test failed to correctly handle conditions involving a concurrently inserted tuple which is later concurrently updated by a separate transaction . A SELECT statement that called HeapCheckForSerializable

pgsql: pg_dump: Remove dead code

2020-06-11 Thread Peter Eisentraut
pg_dump: Remove dead code Remove some code relevant only for dumping from pre-7.1 servers, support for which had already been removed by 64f3524e2c8deebc02808aa5ebdfa17859473add. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d9fa17aa7c34dea66ce64da6fb4c643e75ba452

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c4d5706db298f5a02ffd321c4605a7f8

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/277f154e4f1ccc45b39715d777d8ff6e

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ad9291f5e6f81ebca978c4438a1c7a448ca5b9a

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c419f5f5881fd378f40e93ee1ef0fc5

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/12415fb0561b4abae8163ea556917b9c

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b7ed1d9944005ec443c94d3536be4247

pgsql: Fix typos.

2020-06-11 Thread Amit Kapila
Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fb024f46369b614eb7f12bc9e097b608

pgsql: Refactor DROP LANGUAGE grammar

2020-06-11 Thread Peter Eisentraut
Refactor DROP LANGUAGE grammar Fold it into the generic DropStmt. Discussion: https://www.postgresql.org/message-id/flat/163c00a5-f634-ca52-fc7c-0e53deda8735%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3fbd4bb6f494dd70cc5075536a754261853de167

pgsql: Remove deprecated syntax from CREATE/DROP LANGUAGE

2020-06-11 Thread Peter Eisentraut
Remove deprecated syntax from CREATE/DROP LANGUAGE Remove the option to specify the language name as a single-quoted string. This has been obsolete since ee8ed85da3b. Removing it allows better grammar refactoring. The syntax of the CREATE FUNCTION LANGUAGE clause is not changed. Discussion: h