pgsql: Create by default sql/ and expected/ for output directory in pg_

2020-06-12 Thread Michael Paquier
Create by default sql/ and expected/ for output directory in pg_regress Using --outputdir with a custom output repository has never created by default the sql/ and expected/ paths generated with contents from respectively input/ and output/ if they don't exist, while the base output directory gets

pgsql: Add more TAP tests for pg_dump options with range checks

2020-06-12 Thread Michael Paquier
Add more TAP tests for pg_dump options with range checks This adds two tests for --extra-float-digits and --rows-per-insert, similar to what exists for --compress. Author: Dong Wook Lee Discussion: https://postgr.es/m/caacbyajsgrb-qc-alb0malprrgladmcbap7szxo4kcau-je...@mail.gmail.com Branch ---

pgsql: Have pg_itoa, pg_ltoa and pg_lltoa return the length of the stri

2020-06-12 Thread David Rowley
Have pg_itoa, pg_ltoa and pg_lltoa return the length of the string Core by no means makes excessive use of these functions, but quite a large number of those usages do require the caller to call strlen() on the returned string. This is quite wasteful since these functions do already have a good i

pgsql: Add missing extern keyword for a couple of numutils functions

2020-06-12 Thread David Rowley
Add missing extern keyword for a couple of numutils functions In passing, also remove a few surplus empty lines from pg_ltoa and pg_ulltoa_n in numutils.c Reported-by: Andrew Gierth Discussion: https://postgr.es/m/[email protected] Backpatch-through: 13, where these changes

pgsql: Add missing extern keyword for a couple of numutils functions

2020-06-12 Thread David Rowley
Add missing extern keyword for a couple of numutils functions In passing, also remove a few surplus empty lines from pg_ltoa and pg_ulltoa_n in numutils.c Reported-by: Andrew Gierth Discussion: https://postgr.es/m/[email protected] Backpatch-through: 13, where these changes

pgsql: Avoid using a cursor in plpgsql's RETURN QUERY statement.

2020-06-12 Thread Tom Lane
Avoid using a cursor in plpgsql's RETURN QUERY statement. plpgsql has always executed the query given in a RETURN QUERY command by opening it as a cursor and then fetching a few rows at a time, which it turns around and dumps into the function's result tuplestore. The point of this was to keep fro

pgsql: Fix typos and some format mistakes in comments

2020-06-12 Thread Michael Paquier
Fix typos and some format mistakes in comments Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aaf8c990502f7bb28c10f6bab1d23fe2f9f0b537 Modified Files -- src/back

pgsql: Make more use of RELKIND_HAS_STORAGE()

2020-06-12 Thread Peter Eisentraut
Make more use of RELKIND_HAS_STORAGE() Make use of RELKIND_HAS_STORAGE() where appropriate, instead of listing out the relkinds individually. No behavior change intended. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/7a22bf51-2480-d999-1794-191ba67ff47c%402ndquad