pgsql: Remove useless variable.

2020-06-15 Thread Thomas Munro
Remove useless variable. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4dd804a99cd66d8d336ce7060c91e23db3263c31 Modified Files -- src/backend/storage/file/buffile.c | 2 -- 1 file changed, 2 deletions(-)

pgsql: Make BufFileWrite() void.

2020-06-15 Thread Thomas Munro
Make BufFileWrite() void. It now either returns after it wrote all the data you gave it, or raises an error. Not done in back-branches, because it might cause problems for external code. Discussion: https://postgr.es/m/CA%2BhUKGJE04G%3D8TLK0DLypT_27D9dR8F1RQgNp0jK6qR0tZGWOw%40mail.gmail.com Br

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: Fix buffile.c error handling.

2020-06-15 Thread Thomas Munro
Fix buffile.c error handling. Convert buffile.c error handling to use ereport. This fixes cases where I/O errors were indistinguishable from EOF or not reported. Also remove "%m" from error messages where errno would be bogus. While we're modifying those strings, add block numbers and short rea

pgsql: doc: Document factorial function

2020-06-15 Thread Peter Eisentraut
doc: Document factorial function This has existed for a very long time, equivalent to the ! and !! operators, but it was never documented. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/6ce1df0e-86a3-e544-743a-f357ff663f68%402ndquadrant.com Branch -- master D

Re: pgsql: Fix power() for large inputs yet more.

2020-06-15 Thread Tom Lane
Michael Paquier writes: > fossa seems to still be complaining after that: Yeah. Not sure what to do about that. It seems to be coming to the wrong conclusion about whether yisoddinteger, but I can't think of another way to code that that won't introduce other risks. Worst case answer would be

Re: pgsql: Fix power() for large inputs yet more.

2020-06-15 Thread Michael Paquier
On Mon, Jun 15, 2020 at 11:10:43PM +, Tom Lane wrote: > Fix power() for large inputs yet more. > > Buildfarm results for commit e532b1d57 reveal the error in my thinking > about the unexpected-EDOM case. I'd supposed this was no longer really > a live issue, but it seems the fix for glibc's b

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: pg_upgrade: set vacuum_defer_cleanup_age to zero

2020-06-15 Thread Bruce Momjian
pg_upgrade: set vacuum_defer_cleanup_age to zero Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of the system catalogs to be incomplete, or do nothing. This will cause the upgrade to fail in confusing ways. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/7d6f6c22

pgsql: Fix power() for large inputs yet more.

2020-06-15 Thread Tom Lane
Fix power() for large inputs yet more. Buildfarm results for commit e532b1d57 reveal the error in my thinking about the unexpected-EDOM case. I'd supposed this was no longer really a live issue, but it seems the fix for glibc's bug #3866 is not all that old, and we still have at least one buildfa

pgsql: Assorted cleanup of tar-related code.

2020-06-15 Thread Robert Haas
Assorted cleanup of tar-related code. Introduce TAR_BLOCK_SIZE and replace many instances of 512 with the new constant. Introduce function tarPaddingBytesRequired and use it to replace numerous repetitions of (x + 511) & ~511. Add preprocessor guards against multiple inclusion to pgtar.h. Reform

pgsql: Fix power() for infinity inputs some more.

2020-06-15 Thread Tom Lane
Fix power() for infinity inputs some more. Buildfarm results for commit decbe2bfb show that AIX and illumos have non-POSIX-compliant pow() functions, as do ancient NetBSD and HPUX releases. While it's dubious how much we should care about the latter two platforms, the former two are probably enou

Re: pgsql: Fix behavior of exp() and power() for infinity inputs.

2020-06-15 Thread Tom Lane
Michael Paquier writes: > On Mon, Jun 15, 2020 at 12:10:52AM -0400, Tom Lane wrote: >> Yeah, and presumably Noah's other AIX critters will fail too. I'm curious >> to see what damselfly will say; that's the other old-ish platform we have >> in the farm. Once that reports in, I'm intending to pus

pgsql: Fix some comments referring to past features

2020-06-15 Thread Michael Paquier
Fix some comments referring to past features Timestamp can only be an int64 since b9d092c, and support for WITH OIDS has been removed as of 578b229. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgr

pgsql: pg_dump: Unbreak dumping of aggregates from very old server vers

2020-06-15 Thread Peter Eisentraut
pg_dump: Unbreak dumping of aggregates from very old server versions Recently broken by d9fa17aa7c34dea66ce64da6fb4c643e75ba452c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3baa7e38d51579b69e1228f3e1a43f56001b6d64 Modified Files -- src/bin/pg_dump/

Re: pgsql: Fix behavior of exp() and power() for infinity inputs.

2020-06-15 Thread Michael Paquier
On Mon, Jun 15, 2020 at 12:10:52AM -0400, Tom Lane wrote: > Yeah, and presumably Noah's other AIX critters will fail too. I'm curious > to see what damselfly will say; that's the other old-ish platform we have > in the farm. Once that reports in, I'm intending to push the attached or > something