pgsql: Fix EXPLAIN ANALYZE for parallel HashAgg plans

2020-06-18 Thread David Rowley
Fix EXPLAIN ANALYZE for parallel HashAgg plans Since 1f39bce02, HashAgg nodes have had the ability to spill to disk when memory consumption exceeds work_mem. That commit added new properties to EXPLAIN ANALYZE to show the maximum memory usage and disk usage, however, it didn't quite go as far as s

pgsql: Fix EXPLAIN ANALYZE for parallel HashAgg plans

2020-06-18 Thread David Rowley
Fix EXPLAIN ANALYZE for parallel HashAgg plans Since 1f39bce02, HashAgg nodes have had the ability to spill to disk when memory consumption exceeds work_mem. That commit added new properties to EXPLAIN ANALYZE to show the maximum memory usage and disk usage, however, it didn't quite go as far as s

pgsql: Clean up includes of s_lock.h.

2020-06-18 Thread Andres Freund
Clean up includes of s_lock.h. Users of spinlocks should use spin.h, not s_lock.h. And lwlock.h hasn't utilized spinlocks for quite a while. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/comm

pgsql: Fix C99isms introduced when backpatching atomics / spinlock test

2020-06-18 Thread Andres Freund
Fix C99isms introduced when backpatching atomics / spinlock tests. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5e4beae86d2684eb2f80cbda881eea5351b004ee Modified Files -- src/test/regress/regress.c | 13 - 1 file changed, 8 insertion

pgsql: Fix C99isms introduced when backpatching atomics / spinlock test

2020-06-18 Thread Andres Freund
Fix C99isms introduced when backpatching atomics / spinlock tests. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e6ba7056b499a566af7c792794a5c6f51620c866 Modified Files -- src/test/regress/regress.c | 13 - 1 file changed, 8 insertion

pgsql: Fix C99isms introduced when backpatching atomics / spinlock test

2020-06-18 Thread Andres Freund
Fix C99isms introduced when backpatching atomics / spinlock tests. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f7aefd5158ffea5f5c7b2828658287719d5163d3 Modified Files -- src/test/regress/regress.c | 13 - 1 file changed, 8 insertion

pgsql: Fix C99isms introduced when backpatching atomics / spinlock test

2020-06-18 Thread Andres Freund
Fix C99isms introduced when backpatching atomics / spinlock tests. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/86593365ce40b20f99c0575e79f47da92afe46d7 Modified Files -- src/test/regress/regress.c | 13 - 1 file changed, 8 insertion

Re: pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Hi, On 2020-06-18 17:44:47 -0400, Tom Lane wrote: > Andres Freund writes: > > Add basic spinlock tests to regression tests. > > Looks like you did not make this C89-clean in the back branches. Working on it, sorry for that. Greetings, Andres Freund

Re: pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Tom Lane
Andres Freund writes: > Add basic spinlock tests to regression tests. Looks like you did not make this C89-clean in the back branches. regards, tom lane

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Fix deadlock danger when atomic ops are done under spinlock.

2020-06-18 Thread Andres Freund
Fix deadlock danger when atomic ops are done under spinlock. This was a danger only for --disable-spinlocks in combination with atomic operations unsupported by the current platform. While atomics.c was careful to signal that a separate semaphore ought to be used when spinlock emulation is active

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Add basic spinlock tests to regression tests.

2020-06-18 Thread Andres Freund
Add basic spinlock tests to regression tests. As s_lock_test, the already existing test for spinlocks, isn't run in an automated fashion (and doesn't test a normal backend environment), adding tests that are run as part of a normal regression run is a good idea. Particularly in light of several re

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Doc: document POSIX-style time zone specifications in full.

2020-06-18 Thread Tom Lane
Doc: document POSIX-style time zone specifications in full. We'd glossed over most of this complexity for years, but it's hard to avoid writing it all down now, so that we can explain what happens when there's no "posixrules" file in the IANA time zone database. That was at best a tiny minority si

pgsql: Fix oldest xmin and LSN computation across repslots after advanc

2020-06-18 Thread Michael Paquier
Fix oldest xmin and LSN computation across repslots after advancing Advancing a replication slot did not recompute the oldest xmin and LSN values across replication slots, preventing resource removal like segments not recycled at checkpoint time. The original commit that introduced the slot advan

pgsql: Fix oldest xmin and LSN computation across repslots after advanc

2020-06-18 Thread Michael Paquier
Fix oldest xmin and LSN computation across repslots after advancing Advancing a replication slot did not recompute the oldest xmin and LSN values across replication slots, preventing resource removal like segments not recycled at checkpoint time. The original commit that introduced the slot advan

pgsql: Fix oldest xmin and LSN computation across repslots after advanc

2020-06-18 Thread Michael Paquier
Fix oldest xmin and LSN computation across repslots after advancing Advancing a replication slot did not recompute the oldest xmin and LSN values across replication slots, preventing resource removal like segments not recycled at checkpoint time. The original commit that introduced the slot advan

pgsql: Fix oldest xmin and LSN computation across repslots after advanc

2020-06-18 Thread Michael Paquier
Fix oldest xmin and LSN computation across repslots after advancing Advancing a replication slot did not recompute the oldest xmin and LSN values across replication slots, preventing resource removal like segments not recycled at checkpoint time. The original commit that introduced the slot advan