pgsql: Removal unused function parameter in CopyReadBinaryAttribute.

2020-06-19 Thread Amit Kapila
Removal unused function parameter in CopyReadBinaryAttribute. The function parameter column_no is not used in CopyReadBinaryAttribute, this can be removed. Commit 0e319c7ad7 removed the usage of column_no parameter in function CopyReadBinaryAttribute but forgot to remove the parameter. Reported-

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Ensure write failure reports no-disk-space

2020-06-19 Thread Alvaro Herrera
Ensure write failure reports no-disk-space A few places calling fwrite and gzwrite were not setting errno to ENOSPC when reporting errors, as is customary; this led to some failures being reported as "could not write file: Success" which makes us look silly. Make a few of these places in pg_dump

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Future-proof regression tests against possibly-missing posixrule

2020-06-19 Thread Tom Lane
Future-proof regression tests against possibly-missing posixrules file. The IANA time zone folk have deprecated use of a "posixrules" file in the tz database. While for now it's our choice whether to keep supplying one in our own builds, installations built with --with-system-tzdata will soon be

pgsql: Adjust some glossary terms

2020-06-19 Thread Alvaro Herrera
Adjust some glossary terms Mostly in response to Jürgen Purtz critique of previous definitions, though I added many other changes. Author: Álvaro Herrera Reviewed-by: Jürgen Purtz Reviewed-by: Justin Pryzby Reviewed-by: Erik Rijkers Discussion: https://postgr.es/m/c1e06008-2132-30f4-9b38-877e

pgsql: Adjust some glossary terms

2020-06-19 Thread Alvaro Herrera
Adjust some glossary terms Mostly in response to Jürgen Purtz critique of previous definitions, though I added many other changes. Author: Álvaro Herrera Reviewed-by: Jürgen Purtz Reviewed-by: Justin Pryzby Reviewed-by: Erik Rijkers Discussion: https://postgr.es/m/c1e06008-2132-30f4-9b38-877e

pgsql: Fix deduplication "single value" strategy bug.

2020-06-19 Thread Peter Geoghegan
Fix deduplication "single value" strategy bug. It was possible for deduplication's single value strategy to mistakenly believe that a very small duplicate tuple counts as one of the six large tuples that it aims to leave behind after the page finally splits. This could cause slightly suboptimal s

pgsql: Fix deduplication "single value" strategy bug.

2020-06-19 Thread Peter Geoghegan
Fix deduplication "single value" strategy bug. It was possible for deduplication's single value strategy to mistakenly believe that a very small duplicate tuple counts as one of the six large tuples that it aims to leave behind after the page finally splits. This could cause slightly suboptimal s

pgsql: Fix issues in invalidation of obsolete replication slots.

2020-06-19 Thread Fujii Masao
Fix issues in invalidation of obsolete replication slots. This commit fixes the following issues. 1. There is the case where the slot is dropped while trying to invalidate it. InvalidateObsoleteReplicationSlots() did not handle this case, and which could cause checkpoint to fail. 2. Inva

pgsql: Fix issues in invalidation of obsolete replication slots.

2020-06-19 Thread Fujii Masao
Fix issues in invalidation of obsolete replication slots. This commit fixes the following issues. 1. There is the case where the slot is dropped while trying to invalidate it. InvalidateObsoleteReplicationSlots() did not handle this case, and which could cause checkpoint to fail. 2. Inva