pgsql: Remove erroneous assertion from pg_copy_logical_replication_slot

Remove erroneous assertion from pg_copy_logical_replication_slot(). If restart_lsn of logical replication slot gets behind more than max_slot_wal_keep_size from the current LSN, the logical replication slot would be invalidated and its restart_lsn is reset to an invalid LSN. If this logical replic

pgsql: Remove erroneous assertion from pg_copy_logical_replication_slot

Remove erroneous assertion from pg_copy_logical_replication_slot(). If restart_lsn of logical replication slot gets behind more than max_slot_wal_keep_size from the current LSN, the logical replication slot would be invalidated and its restart_lsn is reset to an invalid LSN. If this logical replic

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

David Steele writes: > ... So apparently it is possible. To get them working as soon as possible I > recommended that they run: > alter role postgres set max_parallel_workers_per_gather = 0; > And that solved their problem. 9.6 is getting on in years so I'm not > sure how much time/effort we wan

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

On 3/6/17 3:28 PM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: David Steele writes: On 3/6/17 12:48 PM, Robert Haas wrote: This issue also exists in 9.6, but we obviously can't do anything about 9.6 clusters that already exist. Possibly this could be back-patched so that fut

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

pgsql: Fix compiler warning induced by commit d8b15eeb8.

Fix compiler warning induced by commit d8b15eeb8. I forgot that INT64_FORMAT can't be used with sscanf on Windows. Use the same trick of sscanf'ing into a temp variable as we do in some other places in zic.c. The upstream IANA code avoids the portability problem by relying on 's SCNdFAST64 macro.

Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

Peter Eisentraut writes: > On 2020-06-18 00:29, Tom Lane wrote: >> Sync our copy of the timezone library with IANA release tzcode2020a. > This code import has introduced new compiler warnings on Windows/mingw > builds, Hmm ... I forgot that INT64_FORMAT can't be used with sscanf. Will fix.

Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

On 2020-06-18 00:29, Tom Lane wrote: Sync our copy of the timezone library with IANA release tzcode2020a. This code import has introduced new compiler warnings on Windows/mingw builds, see for example at

pgsql: Adjust max_slot_wal_keep_size behavior per review

Adjust max_slot_wal_keep_size behavior per review In pg_replication_slot, change output from normal/reserved/lost to reserved/extended/unreserved/ lost, which better expresses the possible states particularly near the time where segments are no longer safe but checkpoint has not run yet. Under th

pgsql: Adjust max_slot_wal_keep_size behavior per review

Adjust max_slot_wal_keep_size behavior per review In pg_replication_slot, change output from normal/reserved/lost to reserved/extended/unreserved/ lost, which better expresses the possible states particularly near the time where segments are no longer safe but checkpoint has not run yet. Under th

pgsql: Save slot's restart_lsn when invalidated due to size

Save slot's restart_lsn when invalidated due to size We put it aside as invalidated_at, which let us show "lost" in pg_replication slot. Prior to this change, the state value was reported as NULL. Backpatch to 13. Author: Kyotaro Horiguchi Reviewed-by: Álvaro Herrera Discussion: https://post

pgsql: Save slot's restart_lsn when invalidated due to size

Save slot's restart_lsn when invalidated due to size We put it aside as invalidated_at, which let us show "lost" in pg_replication slot. Prior to this change, the state value was reported as NULL. Backpatch to 13. Author: Kyotaro Horiguchi Reviewed-by: Álvaro Herrera Discussion: https://post

pgsql: Add parens to ConvertToXSegs macro

Add parens to ConvertToXSegs macro The current definition is dangerous. No bugs exist in our code at present, but backpatch to 11 nonetheless where it was introduced. Author: Álvaro Herrera Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/013d324d51ef55cbff

pgsql: Add parens to ConvertToXSegs macro

Add parens to ConvertToXSegs macro The current definition is dangerous. No bugs exist in our code at present, but backpatch to 11 nonetheless where it was introduced. Author: Álvaro Herrera Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/368d7f3297e7e1304da03904d

pgsql: Add parens to ConvertToXSegs macro

Add parens to ConvertToXSegs macro The current definition (introduced in 9a3215026bd6) is dangerous. No bugs exist in our code at present, but backpatch to 11 nonetheless, where that commit debuted. Author: Álvaro Herrera Branch -- REL_11_STABLE Details --- https://git.postgresql.org/

pgsql: Add parens to ConvertToXSegs macro

Add parens to ConvertToXSegs macro The current definition is dangerous. No bugs exist in our code at present, but backpatch to 11 nonetheless where it was introduced. Author: Álvaro Herrera Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/411493d701e2f97e77

pgsql: Tag refs/tags/REL_13_BETA2 was created

Tag refs/tags/REL_13_BETA2 was created.