Re: pgsql: Fix comments in reorderbuffer.c.

2020-07-17 Thread Amit Kapila
On Sat, Jul 18, 2020 at 10:02 AM David G. Johnston wrote: > > On Friday, July 17, 2020, Amit Kapila wrote: >> >> Fix comments in reorderbuffer.c. >> >> Author: Dave Cramer >> Reviewed-by: David G. Johnston >> Discussion: >> https://postgr.es/m/cadk3hhl8do4fp1bsymgnasx375njv3ar7zy3ugywzbl_dx-...@

pgsql: Adjust minor comment in reorderbuffer.c.

2020-07-17 Thread Amit Kapila
Adjust minor comment in reorderbuffer.c. Author: Dave Cramer Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/cadk3hhl8do4fp1bsymgnasx375njv3ar7zy3ugywzbl_dx-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f41fbee7e704947fd1d2241f35

pgsql: Fix comments in reorderbuffer.c.

2020-07-17 Thread David G. Johnston
On Friday, July 17, 2020, Amit Kapila wrote: > Fix comments in reorderbuffer.c. > > Author: Dave Cramer > Reviewed-by: David G. Johnston > Discussion: https://postgr.es/m/CADK3HHL8do4Fp1bsymgNasx375njV3AR7zY3UgY > [email protected] > The discussion ended with Dave agreeing with me about

pgsql: Fix comments in reorderbuffer.c.

2020-07-17 Thread Amit Kapila
Fix comments in reorderbuffer.c. Author: Dave Cramer Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/cadk3hhl8do4fp1bsymgnasx375njv3ar7zy3ugywzbl_dx-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/df7c5cb16e8fcf960e3302355fa6547fba

pgsql: doc: Fix description of \copy for psql

2020-07-17 Thread Michael Paquier
doc: Fix description of \copy for psql The WHERE clause introduced by 31f3817 was not described. While on it, split the grammar of \copy FROM and TO into two distinct parts for clarity as they support different set of options. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm3zWr=OmxeNq

pgsql: doc: Fix description of \copy for psql

2020-07-17 Thread Michael Paquier
doc: Fix description of \copy for psql The WHERE clause introduced by 31f3817 was not described. While on it, split the grammar of \copy FROM and TO into two distinct parts for clarity as they support different set of options. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm3zWr=OmxeNq

pgsql: doc: Fix description of \copy for psql

2020-07-17 Thread Michael Paquier
doc: Fix description of \copy for psql The WHERE clause introduced by 31f3817 was not described. While on it, split the grammar of \copy FROM and TO into two distinct parts for clarity as they support different set of options. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm3zWr=OmxeNq

pgsql: Rename "hash_mem" local variable.

2020-07-17 Thread Peter Geoghegan
Rename "hash_mem" local variable. The term "hash_mem" will take on new significance when pending work to add a new hash_mem_multiplier GUC is committed. Rename a local variable that happens to have been called hash_mem now to avoid confusion. Branch -- master Details --- https://git.pos

pgsql: Add Valgrind buffer access instrumentation.

2020-07-17 Thread Peter Geoghegan
Add Valgrind buffer access instrumentation. Teach Valgrind memcheck to maintain the "defined-ness" of each shared buffer based on whether the backend holds at least one pin at the point it is accessed by access method code. Bugs like the one fixed by commit b0229f26 can be detected using this new

pgsql: Cope with data-offset-less archive files during out-of-order res

2020-07-17 Thread Tom Lane
Cope with data-offset-less archive files during out-of-order restores. pg_dump produces custom-format archive files that lack data offsets when it is unable to seek its output. Up to now that's been a hazard for pg_restore. But if pg_restore is able to seek in the archive file, there is no reaso

pgsql: Remove manual tracking of file position in pg_dump/pg_backup_cus

2020-07-17 Thread Tom Lane
Remove manual tracking of file position in pg_dump/pg_backup_custom.c. We do not really need to track the file position by hand. We were already relying on ftello() whenever the archive file is seekable, while if it's not seekable we don't need the file position info anyway because we're not goin

pgsql: Remove manual tracking of file position in pg_dump/pg_backup_cus

2020-07-17 Thread Tom Lane
Remove manual tracking of file position in pg_dump/pg_backup_custom.c. We do not really need to track the file position by hand. We were already relying on ftello() whenever the archive file is seekable, while if it's not seekable we don't need the file position info anyway because we're not goin

pgsql: Remove manual tracking of file position in pg_dump/pg_backup_cus

2020-07-17 Thread Tom Lane
Remove manual tracking of file position in pg_dump/pg_backup_custom.c. We do not really need to track the file position by hand. We were already relying on ftello() whenever the archive file is seekable, while if it's not seekable we don't need the file position info anyway because we're not goin

pgsql: Cope with data-offset-less archive files during out-of-order res

2020-07-17 Thread Tom Lane
Cope with data-offset-less archive files during out-of-order restores. pg_dump produces custom-format archive files that lack data offsets when it is unable to seek its output. Up to now that's been a hazard for pg_restore. But if pg_restore is able to seek in the archive file, there is no reaso

pgsql: Cope with data-offset-less archive files during out-of-order res

2020-07-17 Thread Tom Lane
Cope with data-offset-less archive files during out-of-order restores. pg_dump produces custom-format archive files that lack data offsets when it is unable to seek its output. Up to now that's been a hazard for pg_restore. But if pg_restore is able to seek in the archive file, there is no reaso

pgsql: Avoid CREATE INDEX unique index deduplication.

2020-07-17 Thread Peter Geoghegan
Avoid CREATE INDEX unique index deduplication. There is no advantage to attempting deduplication for a unique index during CREATE INDEX, since there cannot possibly be any duplicates. Doing so wastes cycles due to unnecessary copying. Make sure that we avoid it consistently. We already avoided u

pgsql: Avoid CREATE INDEX unique index deduplication.

2020-07-17 Thread Peter Geoghegan
Avoid CREATE INDEX unique index deduplication. There is no advantage to attempting deduplication for a unique index during CREATE INDEX, since there cannot possibly be any duplicates. Doing so wastes cycles due to unnecessary copying. Make sure that we avoid it consistently. We already avoided u

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Ensure that distributed timezone abbreviation files are plain AS

2020-07-17 Thread Tom Lane
Ensure that distributed timezone abbreviation files are plain ASCII. We had two occurrences of "Mitteleuropäische Zeit" in Europe.txt, though the corresponding entries in Default were spelled "Mitteleuropaeische Zeit". Standardize on the latter spelling to avoid questions of which encoding to use

pgsql: Fix whitespace

2020-07-17 Thread Peter Eisentraut
Fix whitespace Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dafa153dda82d335a46e2a3b48247b7fcb308d4e Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix whitespace

2020-07-17 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20ef35516328350a244d22b590e37f24ea958526 Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix whitespace

2020-07-17 Thread Peter Eisentraut
Fix whitespace Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ca744cd5c46ae35ff59d6be865cd80f3a366b94 Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix whitespace

2020-07-17 Thread Peter Eisentraut
Fix whitespace Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6bab40bf605665fc01b84a434127cbaec3b3d1de Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Resolve gratuitous tabs in SQL file

2020-07-17 Thread Peter Eisentraut
Resolve gratuitous tabs in SQL file Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/44f34365b81fd1be575d212593c2bd9c47060aa6 Modified Files -- src/backend/catalog/system_views.sql | 8 1 file changed, 4 insertions(+), 4 deletions(-)

pgsql: Resolve gratuitous tabs in SQL file

2020-07-17 Thread Peter Eisentraut
Resolve gratuitous tabs in SQL file Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e7240ccecd3001892880fd076a7ffd107b533afc Modified Files -- src/backend/catalog/system_views.sql | 8 1 file changed, 4 insertions(+), 4 deletions(-)

pgsql: Add huge_page_size setting for use on Linux.

2020-07-17 Thread Thomas Munro
Add huge_page_size setting for use on Linux. This allows the huge page size to be set explicitly. The default is 0, meaning it will use the system default, as before. Author: Odin Ugedal Discussion: https://postgr.es/m/20200608154639.20254-1-odin%40ugedal.com Branch -- master Details

pgsql: Use MinimalTuple for tuple queues.

2020-07-17 Thread Thomas Munro
Use MinimalTuple for tuple queues. This representation saves 8 bytes per tuple compared to HeapTuple, and avoids the need to allocate, copy and free on the receiving side. Gather can emit the returned MinimalTuple directly, but GatherMerge now needs to make an explicit copy because it buffers mul