pgsql: Doc: update v13 release notes for changes through today.

2020-08-09 Thread Tom Lane
Doc: update v13 release notes for changes through today. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bc635dd16388015c72e47a4b90c4c3ceecebb0cd Modified Files -- doc/src/sgml/release-13.sgml | 158 +++ 1 fi

pgsql: Correct nbtree page split lock coupling comment.

2020-08-09 Thread Peter Geoghegan
Correct nbtree page split lock coupling comment. There is no reason to distinguish between readers and writers here. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d129c07499dbf0d5960115173515e3ce384c662a Modified Files -- src/backend/access/nbtree/nbt

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

2020-08-09 Thread Tom Lane
Check for fseeko() failure in pg_dump's _tarAddFile(). Coverity pointed out, not unreasonably, that we checked fseeko's result at every other call site but these. Failure to seek in the temp file (note this is NOT pg_dump's output file) seems quite unlikely, and even if it did happen the file len

pgsql: Remove useless Assert.

2020-08-09 Thread Tom Lane
Remove useless Assert. Testing that an unsigned variable is >= 0 is pretty pointless, as noted by Coverity and numerous buildfarm members. In passing, add comment about new uses of "volatile" --- Coverity doesn't much like that either, but it seems probably necessary. Branch -- master Detai